From: Johannes Berg <johannes@sipsolutions.net>
To: Martin Pitt <martin.pitt@ubuntu.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Dan Williams <dcbw@redhat.com>
Subject: Re: [PATCH] mac80211_hwsim: Register and bind to driver
Date: Mon, 08 Apr 2013 11:12:54 +0200 [thread overview]
Message-ID: <1365412374.25475.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130408090633.GB2818@piware.de>
Looks fine, but ...
> @@ -2179,6 +2183,8 @@ static int __init init_mac80211_hwsim(void)
> if (IS_ERR(hwsim_class))
> return PTR_ERR(hwsim_class);
>
> + driver_register(&mac80211_hwsim_driver);
> +
> memset(addr, 0, ETH_ALEN);
> addr[0] = 0x02;
I think you forgot to update the error path to unregister the driver.
johannes
next prev parent reply other threads:[~2013-04-08 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 9:06 [PATCH] mac80211_hwsim: Register and bind to driver Martin Pitt
2013-04-08 9:12 ` Johannes Berg [this message]
[not found] ` <1365412374.25475.2.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-04-08 9:28 ` Martin Pitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365412374.25475.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dcbw@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=martin.pitt@ubuntu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).