From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] net: mv643xx_eth: remove deprecated inet_lro support Date: Thu, 11 Apr 2013 12:46:57 -0700 Message-ID: <1365709617.3887.185.camel@edumazet-glaptop> References: <1365707488-28819-1-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Lennert Buytenhek , Andrew Lunn , Jason Cooper , Florian Fainelli , Benjamin Herrenschmidt , Paul Mackerras , Dale Farnsworth , Ben Hutchings , Soeren Moch , Willy Tarreau , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org To: Sebastian Hesselbarth Return-path: In-Reply-To: <1365707488-28819-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2013-04-11 at 21:11 +0200, Sebastian Hesselbarth wrote: > With recent support for GRO, there is no need to keep both LRO and > GRO. This patch therefore removes the deprecated inet_lro support > from mv643xx_eth. This is work is based on an experimental patch > provided by Eric Dumazet and Willy Tarreau. > > Signed-off-by: Sebastian Hesselbarth > Based-on-patch-by: Eric Dumazet > Based-on-patch-by: Willy Tarreau > --- > Note: This patch is based upon recent cleanup patches and GRO support > patch for mv643xx_eth. > > Cc: "David S. Miller" > Cc: Lennert Buytenhek > Cc: Andrew Lunn > Cc: Jason Cooper > Cc: Florian Fainelli > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Dale Farnsworth > Cc: Ben Hutchings > Cc: Soeren Moch > Cc: Eric Dumazet > Cc: Willy Tarreau > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 97 +--------------------------- > 1 file changed, 3 insertions(+), 94 deletions(-) Seems fine to me, but you also could remove "select INET_LRO" from drivers/net/ethernet/marvell/Kconfig