From: Wei Liu <wei.liu2@citrix.com>
To: <netdev@vger.kernel.org>, <xen-devel@lists.xen.org>
Cc: <annie.li@oracle.com>, <konrad.wilk@oracle.com>,
<jbeulich@suse.com>, <ian.campbell@citrix.com>,
<wdauchy@gmail.com>, <david.vrabel@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH V4 3/7] xen-netback: remove skb in xen_netbk_alloc_page
Date: Fri, 12 Apr 2013 15:24:02 +0100 [thread overview]
Message-ID: <1365776646-10796-4-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1365776646-10796-1-git-send-email-wei.liu2@citrix.com>
This variable is never used.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
drivers/net/xen-netback/netback.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index da726a3..6e8e51a 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -948,7 +948,6 @@ static int netbk_count_requests(struct xenvif *vif,
}
static struct page *xen_netbk_alloc_page(struct xen_netbk *netbk,
- struct sk_buff *skb,
u16 pending_idx)
{
struct page *page;
@@ -982,7 +981,7 @@ static struct gnttab_copy *xen_netbk_get_requests(struct xen_netbk *netbk,
index = pending_index(netbk->pending_cons++);
pending_idx = netbk->pending_ring[index];
- page = xen_netbk_alloc_page(netbk, skb, pending_idx);
+ page = xen_netbk_alloc_page(netbk, pending_idx);
if (!page)
goto err;
@@ -1387,7 +1386,7 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk)
}
/* XXX could copy straight to head */
- page = xen_netbk_alloc_page(netbk, skb, pending_idx);
+ page = xen_netbk_alloc_page(netbk, pending_idx);
if (!page) {
kfree_skb(skb);
netbk_tx_err(vif, &txreq, idx);
--
1.7.10.4
next prev parent reply other threads:[~2013-04-12 14:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 14:23 [PATCH V4 0/7] Bundle fixes for Xen netfront / netback Wei Liu
2013-04-12 14:24 ` [PATCH V4 1/7] xen-netfront: remove unused variable `extra' Wei Liu
2013-04-12 14:24 ` [PATCH V4 2/7] xen-netfront: frags -> slots in xennet_get_responses Wei Liu
2013-04-12 14:24 ` Wei Liu [this message]
2013-04-12 14:24 ` [PATCH V4 4/7] xen-netfront: frags -> slots in log message Wei Liu
2013-04-12 14:41 ` Ian Campbell
2013-04-12 14:24 ` [PATCH V4 5/7] xen-netfront: reduce gso_max_size to account for max TCP header Wei Liu
2013-04-12 14:44 ` Ian Campbell
2013-04-12 15:07 ` Jan Beulich
2013-04-12 14:24 ` [PATCH V4 6/7] xen-netback: coalesce slots in TX path and fix regressions Wei Liu
2013-04-12 15:35 ` Ian Campbell
2013-04-14 16:15 ` Wei Liu
2013-04-12 14:24 ` [PATCH V4 7/7] xen-netback: don't disconnect frontend when seeing oversize packet Wei Liu
2013-04-12 15:38 ` Ian Campbell
2013-04-12 17:17 ` William Dauchy
2013-04-15 9:03 ` Ian Campbell
2013-04-15 14:53 ` Wei Liu
2013-04-15 15:22 ` Wei Liu
2013-04-15 15:24 ` Ian Campbell
2013-04-15 15:30 ` Wei Liu
2013-04-15 15:35 ` Ian Campbell
2013-04-15 15:39 ` Wei Liu
2013-04-15 17:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365776646-10796-4-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=annie.li@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wdauchy@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).