* [PATCH] fec: Fix PHC device log
@ 2013-04-13 16:38 Fabio Estevam
2013-04-13 16:49 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2013-04-13 16:38 UTC (permalink / raw)
To: davem; +Cc: Frank.Li, netdev, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently when booting a mx6 device we get the following on boot:
registered PHC device on eth%d
Fix it so that we can read:
registered PHC device on eth0
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 1f17ca0..62e39fe 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -380,6 +380,6 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev)
fep->ptp_clock = NULL;
pr_err("ptp_clock_register failed\n");
} else {
- pr_info("registered PHC device on %s\n", ndev->name);
+ pr_info("registered PHC device on eth%d\n", fep->dev_id);
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fec: Fix PHC device log
2013-04-13 16:38 [PATCH] fec: Fix PHC device log Fabio Estevam
@ 2013-04-13 16:49 ` Joe Perches
2013-04-13 16:54 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2013-04-13 16:49 UTC (permalink / raw)
To: Fabio Estevam; +Cc: davem, Frank.Li, netdev, Fabio Estevam
On Sat, 2013-04-13 at 13:38 -0300, Fabio Estevam wrote:
> Currently when booting a mx6 device we get the following on boot:
> registered PHC device on eth%d
[]
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
[]
> @@ -380,6 +380,6 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev)
> fep->ptp_clock = NULL;
> pr_err("ptp_clock_register failed\n");
> } else {
> - pr_info("registered PHC device on %s\n", ndev->name);
> + pr_info("registered PHC device on eth%d\n", fep->dev_id);
Maybe better as:
netdev_info(ndev, "registered PHC device %d\n", fep->dev_id);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fec: Fix PHC device log
2013-04-13 16:49 ` Joe Perches
@ 2013-04-13 16:54 ` Fabio Estevam
2013-04-13 17:10 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2013-04-13 16:54 UTC (permalink / raw)
To: Joe Perches; +Cc: davem, Frank.Li, netdev, Fabio Estevam
On Sat, Apr 13, 2013 at 1:49 PM, Joe Perches <joe@perches.com> wrote:
> Maybe better as:
> netdev_info(ndev, "registered PHC device %d\n", fep->dev_id);
In this case I get:
fec 2188000.ethernet (unregistered net_device): registered PHC device 0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fec: Fix PHC device log
2013-04-13 16:54 ` Fabio Estevam
@ 2013-04-13 17:10 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2013-04-13 17:10 UTC (permalink / raw)
To: Fabio Estevam; +Cc: davem, Frank.Li, netdev, Fabio Estevam
On Sat, 2013-04-13 at 13:54 -0300, Fabio Estevam wrote:
> On Sat, Apr 13, 2013 at 1:49 PM, Joe Perches <joe@perches.com> wrote:
>
> > Maybe better as:
> > netdev_info(ndev, "registered PHC device %d\n", fep->dev_id);
>
> In this case I get:
>
> fec 2188000.ethernet (unregistered net_device): registered PHC device 0
Everything in fec_probe between the alloc_etherdev
and register_netdev would get that, but the actual
registered netdev name perhaps is not guaranteed to
be fep->dev_id.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-13 17:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-13 16:38 [PATCH] fec: Fix PHC device log Fabio Estevam
2013-04-13 16:49 ` Joe Perches
2013-04-13 16:54 ` Fabio Estevam
2013-04-13 17:10 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).