From: Joe Perches <joe@perches.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: davem@davemloft.net, Frank.Li@freescale.com,
netdev@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] fec: Fix PHC device log
Date: Sat, 13 Apr 2013 09:49:39 -0700 [thread overview]
Message-ID: <1365871779.2358.3.camel@joe-AO722> (raw)
In-Reply-To: <1365871134-6834-1-git-send-email-festevam@gmail.com>
On Sat, 2013-04-13 at 13:38 -0300, Fabio Estevam wrote:
> Currently when booting a mx6 device we get the following on boot:
> registered PHC device on eth%d
[]
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
[]
> @@ -380,6 +380,6 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev)
> fep->ptp_clock = NULL;
> pr_err("ptp_clock_register failed\n");
> } else {
> - pr_info("registered PHC device on %s\n", ndev->name);
> + pr_info("registered PHC device on eth%d\n", fep->dev_id);
Maybe better as:
netdev_info(ndev, "registered PHC device %d\n", fep->dev_id);
next prev parent reply other threads:[~2013-04-13 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 16:38 [PATCH] fec: Fix PHC device log Fabio Estevam
2013-04-13 16:49 ` Joe Perches [this message]
2013-04-13 16:54 ` Fabio Estevam
2013-04-13 17:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365871779.2358.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).