From: Keith Owens <kaos@ocs.com.au>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: Linus Torvalds <torvalds@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>,
David Lang <david.lang@digitalinsight.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Netdev List <netdev@vger.kernel.org>
Subject: Re: [git patch] urgent e1000 fix
Date: Fri, 24 Jun 2005 18:22:59 +1000 [thread overview]
Message-ID: <13661.1119601379@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Fri, 24 Jun 2005 09:49:05 +0300." <200506240949.05620.vda@ilport.com.ua>
On Fri, 24 Jun 2005 09:49:05 +0300,
Denis Vlasenko <vda@ilport.com.ua> wrote:
>On Friday 24 June 2005 02:33, Linus Torvalds wrote:
>> To actually allow real fuzz or to allow real whitespace differences in the
>> patch data itself is a _much_ bigger issue than this trivial patch
>> corruption, and I'd prefer to avoid going there if at all possible.
>
>How about automatic stripping of _trailing_ whitespace on all incoming
>patches? IIRC no file type (C, sh, Makefile, you name it) depends on
>conservation of it, thus it's 100% safe.
One (admittedly rare) case - adding a text file that contains an
embedded patch, so you have a patch that includes a patch. This is
sometimes done in Documentation files when an external file has to be
changed. In embedded patch, empty lines are converted to a single
space, which then appears as trailing whitespace. Not sure if that is
a big enough reason not to strip whitespace.
next prev parent reply other threads:[~2005-06-24 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 9:24 [git patch] urgent e1000 fix Jeff Garzik
2005-06-23 21:04 ` David Lang
2005-06-23 21:19 ` Jeff Garzik
2005-06-23 22:08 ` Linus Torvalds
2005-06-23 23:10 ` Jeff Garzik
2005-06-23 23:33 ` Linus Torvalds
2005-06-24 6:49 ` Denis Vlasenko
2005-06-24 8:22 ` Keith Owens [this message]
2005-06-24 8:51 ` Linus Torvalds
2005-06-24 10:14 ` Tomasz Kłoczko
2005-06-24 16:40 ` Linus Torvalds
2005-06-24 15:11 ` Horst von Brand
2005-06-23 23:20 ` David Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13661.1119601379@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=akpm@osdl.org \
--cc=david.lang@digitalinsight.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).