From: Jesse Gross <jesse@nicira.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
Hong Zhiguo <honkiko@gmail.com>, Jesse Gross <jesse@nicira.com>
Subject: [PATCH net 2/2] openvswitch: correct an invalid BUG_ON
Date: Tue, 16 Apr 2013 13:17:29 -0700 [thread overview]
Message-ID: <1366143449-8605-3-git-send-email-jesse@nicira.com> (raw)
In-Reply-To: <1366143449-8605-1-git-send-email-jesse@nicira.com>
From: Hong Zhiguo <honkiko@gmail.com>
table->count is uint32_t
Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---
net/openvswitch/flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index fe0e421..67a2b78 100644
--- a/net/openvswitch/flow.c
+++ b/net/openvswitch/flow.c
@@ -795,9 +795,9 @@ void ovs_flow_tbl_insert(struct flow_table *table, struct sw_flow *flow)
void ovs_flow_tbl_remove(struct flow_table *table, struct sw_flow *flow)
{
+ BUG_ON(table->count == 0);
hlist_del_rcu(&flow->hash_node[table->node_ver]);
table->count--;
- BUG_ON(table->count < 0);
}
/* The size of the argument for each %OVS_KEY_ATTR_* Netlink attribute. */
--
1.7.10.4
next prev parent reply other threads:[~2013-04-16 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 20:17 [GIT net] Open vSwitch Jesse Gross
2013-04-16 20:17 ` [PATCH net 1/2] openvswitch: Preallocate reply skb in ovs_vport_cmd_set() Jesse Gross
2013-04-16 20:17 ` Jesse Gross [this message]
2013-04-16 20:53 ` [GIT net] Open vSwitch David Miller
2013-04-18 2:31 ` Jesse Gross
2013-04-18 2:37 ` David Miller
2013-04-18 4:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366143449-8605-3-git-send-email-jesse@nicira.com \
--to=jesse@nicira.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).