Re: [RFC PATCH] udp: don't rereference dst_entry dev pointer on rcv

Damien Wyart
2013-03-23T10:40:10Z

Hi Eric,

* Tom Parkin <tparkin@katalix.com> [2013-03-14 16:14]:
> On Thu, Mar 14, 2013 at 04:29:06PM +0100, Eric Dumazet wrote:
> > OK, I tested the following one instead, please test it so that I can send an official patch.

> > Thanks

> > diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c
> > index b6d30ac..2d23830 100644
> > --- a/net/ipv4/ip_fragment.c
> > +++ b/net/ipv4/ip_fragment.c
> > @@ -529,6 +529,7 @@ found:
> > qp->q.meat == qp->q.len)
> > return ip_frag_reasm(qp, prev, dev);

> > + skb_dst_drop(skb);
> > inet_frag_lru_move(&qp->q);
> > return -EINPROGRESS;

> Thanks again, Eric.

> Sadly, with this patch the oops is back :-( It falls over quite
> quickly for me.

Just a quick check: do you plan to have another look at this in the
coming days/weeks? You said you had a huge backlog, but in the meantime,
you sent many patches on many topics, so just wanted to check if this
one had not be forgotten for ever.

Thanks,
--
Damien Wyart