Re: [RFC PATCH] udp: don't rereference dst_entry dev pointer on rcv

Tom Parkin
2013-03-14T16:14:40Z

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

On Thu, Mar 14, 2013 at 04:29:06PM +0100, Eric Dumazet wrote:
> OK, I tested the following one instead, please test it so that I can send an official patch.
>
> Thanks
>
> diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c
> index b6d30ac..2d23830 100644
> --- a/net/ipv4/ip_fragment.c
> +++ b/net/ipv4/ip_fragment.c
> @@ -529,6 +529,7 @@ found:
> qp->q.meat == qp->q.len)
> return ip_frag_reasm(qp, prev, dev);
>
> + skb_dst_drop(skb);
> inet_frag_lru_move(&qp->q);
> return -EINPROGRESS;
>

Thanks again, Eric.

Sadly, with this patch the oops is back :-( It falls over quite
quickly for me.
--
Tom Parkin
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]