Re: [RFC PATCH] udp: don't rereference dst_entry dev pointer on rcv

David Miller
2013-04-12T22:32:52Z

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 11 Apr 2013 15:26:33 -0700

> On Thu, 2013-04-11 at 10:53 -0700, Eric Dumazet wrote:
>> On Thu, 2013-04-11 at 09:32 -0700, Eric Dumazet wrote:
>>
>> > Short update : I do not understand yet why this patch is not working.
>> >
>> > Normally, the reassembled packet should get the dst from the last skb
>> > (the one completing the packet)...
>> >
>> > I have to make more experiments.
>>
>> OK I think I've nailed it, please try following patch (I tried it on
>> net-next, but it should apply on previous kernels)
>
> By the way I am ashamed by commit 64f3b9e203bd068550
> (net: ip_expire() must revalidate route)
>
> Reading its changelog now, I understand I should have fixed this the
> way we did today...
>
> :(

There is still time to do it the right way Eric :-)