From: Cong Wang <amwang@redhat.com>
To: Mike Rapoport <mike.rapoport@ravellosystems.com>
Cc: netdev@vger.kernel.org, David Stevens <dlstevens@us.ibm.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v4 3/5] vxlan: add ipv6 support
Date: Wed, 17 Apr 2013 21:18:12 +0800 [thread overview]
Message-ID: <1366204692.700.8.camel@cr0> (raw)
In-Reply-To: <CAF1J0HNu9i_N2AtxvKL=edsVbZpZCsJL0mh2HEfF2G28CYcHYA@mail.gmail.com>
On Wed, 2013-04-17 at 13:36 +0300, Mike Rapoport wrote:
> Well, I think that the address comparison helpers,
> vxlan_nla_{get,put}_addr, vxlan_newlink and vxlan_fill_info can be
> left with run-time checks only. Maybe some other places as well.
> Removing the ifdefs will increase compile time for kernels configured
> with IPV6=n, and may have certain run-time performance impact for such
> kernels. On the other hand, less ifdefs means better readability :).
In theory, yes; in this case, I don't think having these ifdefs harms
the readability.
next prev parent reply other threads:[~2013-04-17 13:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 5:10 [Patch net-next v4 0/5] vxlan: add ipv6 support Cong Wang
2013-04-17 5:10 ` [Patch net-next v4 1/5] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-17 5:10 ` [Patch net-next v4 2/5] ipv6: export ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-17 5:10 ` [Patch net-next v4 3/5] vxlan: add ipv6 support Cong Wang
2013-04-17 8:15 ` Mike Rapoport
2013-04-17 9:57 ` Cong Wang
2013-04-17 10:36 ` Mike Rapoport
2013-04-17 13:18 ` Cong Wang [this message]
2013-04-17 16:34 ` Mike Rapoport
2013-04-18 14:34 ` Mike Rapoport
2013-04-19 11:35 ` Cong Wang
2013-04-17 5:10 ` [Patch net-next v4 4/5] vxlan: add scope_id support for ll addr Cong Wang
2013-04-18 13:36 ` Cong Wang
2013-04-19 11:14 ` David Stevens
2013-04-19 11:56 ` Cong Wang
2013-04-21 13:47 ` Cong Wang
2013-04-21 14:46 ` Bjørn Mork
2013-04-21 14:57 ` Cong Wang
2013-04-21 15:10 ` Bjørn Mork
2013-04-17 5:10 ` [Patch net-next v4 5/5] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-04-18 17:23 ` Pravin Shelar
2013-04-19 11:30 ` Cong Wang
2013-04-17 5:10 ` [PATCH iproute2] vxlan: add ipv6 support Cong Wang
2013-04-18 22:55 ` Stephen Hemminger
2013-04-19 11:36 ` Cong Wang
2013-04-18 22:57 ` Stephen Hemminger
2013-04-19 14:20 ` Cong Wang
2013-04-19 15:26 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366204692.700.8.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).