netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
	Frank Li <Frank.Li@freescale.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Fabio Estevam <festevam@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: [PATCH 0/3] URGENT for 3.9: net: fec: revert NAPI introduction
Date: Fri, 19 Apr 2013 16:36:01 +0200	[thread overview]
Message-ID: <1366382164-10968-1-git-send-email-l.stach@pengutronix.de> (raw)

Those patches introduce instability to the point of kernel OOPSes with
NULL-ptr dereferences.

The patches drop locks from the code without justifying why this would
be safe at all. In fact it isn't safe as now the controller restart can
happily free the RX and TX ring buffers while the NAPI poll function is
still accessing them. So with a heavily loaded but slightly instable
link we regularly end up with OOPSes because link change restarts
the FEC and bombs away buffers still in use.

Also the NAPI enabled interrupt handler ACKs the INT and only later
masks it, this way introducing a window where new interrupts could sneak
in while we are already in polling mode.

As it's way too late in the cycle to try and fix this up just revert the
relevant patches for now.

Lucas Stach (3):
  Revert "net: fec: fix missing napi_disable call"
  Revert "net: fec: put tx to napi poll function to fix dead lock"
  Revert "net: fec: add napi support to improve proformance"

 drivers/net/ethernet/freescale/fec.c | 126 ++++++++++++++---------------------
 drivers/net/ethernet/freescale/fec.h |   5 +-
 2 files changed, 53 insertions(+), 78 deletions(-)

-- 
1.8.2.rc2

             reply	other threads:[~2013-04-19 14:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 14:36 Lucas Stach [this message]
2013-04-19 14:36 ` [PATCH 1/3] Revert "net: fec: fix missing napi_disable call" Lucas Stach
2013-04-19 14:36 ` [PATCH 2/3] Revert "net: fec: put tx to napi poll function to fix dead lock" Lucas Stach
2013-04-19 14:36 ` [PATCH 3/3] Revert "net: fec: add napi support to improve proformance" Lucas Stach
2013-04-19 17:38 ` [PATCH 0/3] URGENT for 3.9: net: fec: revert NAPI introduction David Miller
2013-04-25 12:44   ` Lucas Stach
2013-04-25 19:14     ` David Miller
2013-04-19 18:22 ` Fabio Estevam
2013-04-19 18:26   ` David Miller
2013-04-19 20:05 ` Fabio Estevam
2013-04-20 12:35   ` Frank Li
2013-04-22  8:56     ` Lucas Stach
2013-04-22  9:17       ` Frank Li
2013-04-25 12:31         ` Lucas Stach
2013-04-25 14:45           ` Frank Li
2013-04-25 14:57             ` Lucas Stach
2013-04-27  7:12               ` Frank Li
2013-04-25 12:37   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366382164-10968-1-git-send-email-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=Frank.Li@freescale.com \
    --cc=davem@davemloft.net \
    --cc=festevam@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).