From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH] tcp: call tcp_replace_ts_recent() from tcp_ack()
Date: Fri, 19 Apr 2013 10:01:59 -0700 [thread overview]
Message-ID: <1366390919.16391.25.camel@edumazet-glaptop> (raw)
In-Reply-To: <1366390793.16391.24.camel@edumazet-glaptop>
On Fri, 2013-04-19 at 09:59 -0700, Eric Dumazet wrote:
> On Fri, 2013-04-19 at 12:33 -0400, Neal Cardwell wrote:
>
> > This patch looks good. But AFAICT the other call site for
> > tcp_replace_ts_recent() has the same bug, which can be fixed in the
> > same way: tcp_rcv_state_process() seems to fall through the big switch
> > statement down to its call to tcp_replace_ts_recent() even in some
> > cases where tcp_ack() already decided the ACK was unacceptable.
>
> I was not sure of the second call site, and was willing to discuss this
> with you and Yuchung.
>
> Are you comfortable this is net material and not net-next ? (We are
> talking of states other than ESTABLISHED)
The other concern was about conflict with the prior net-next patch (tcp:
remove one indentation level in tcp_rcv_state_process())
next prev parent reply other threads:[~2013-04-19 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 15:13 [PATCH] tcp: call tcp_replace_ts_recent() from tcp_ack() Eric Dumazet
2013-04-19 16:33 ` Neal Cardwell
2013-04-19 16:59 ` Eric Dumazet
2013-04-19 17:01 ` Eric Dumazet [this message]
2013-04-19 17:14 ` Neal Cardwell
2013-04-19 17:18 ` Eric Dumazet
2013-04-19 17:19 ` [PATCH v2] " Eric Dumazet
2013-04-19 17:31 ` Neal Cardwell
2013-04-19 18:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366390919.16391.25.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox