From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jeroen Van den Keybus <jeroen.vandenkeybus@triphase.com>,
bruce.w.allan@intel.com, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH net] e1000e: fix numeric overflow in phc settime method.
Date: Mon, 22 Apr 2013 10:53:22 -0700 [thread overview]
Message-ID: <1366653202.2037.2.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1455e8dd5f574fef93377b61cea8b494102091ef.1366638698.git.richardcochran@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Mon, 2013-04-22 at 15:53 +0200, Richard Cochran wrote:
>
> The PTP Hardware Clock settime function in the e1000e driver
> computes nanoseconds from a struct timespec. The code converts the
> seconds field .tv_sec by multiplying it with NSEC_PER_SEC. However,
> both operands are of type long, resulting in an unintended overflow.
> The patch fixes the issue by using the helper function from time.h.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000e/ptp.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Thanks Richard, I will add this to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-22 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:53 [PATCH net] e1000e: fix numeric overflow in phc settime method Richard Cochran
2013-04-22 17:53 ` Jeff Kirsher [this message]
2013-04-22 17:56 ` Richard Cochran
2013-04-22 18:17 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366653202.2037.2.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeroen.vandenkeybus@triphase.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).