From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [Patch net-next v5 0/5] vxlan: add ipv6 support
Date: Tue, 23 Apr 2013 14:27:35 +0800	[thread overview]
Message-ID: <1366698455.21136.11.camel@cr0> (raw)
In-Reply-To: <1366687841.21136.6.camel@cr0>
On Tue, 2013-04-23 at 11:30 +0800, Cong Wang wrote:
> On Mon, 2013-04-22 at 16:08 -0400, David Miller wrote:
> > 
> > Please do not fix this by adding Kconfig dependencies, you have to
> > find another way.  In bonding and bridging, we've made it such that
> > you can configure them in any combination whatsoever with ipv6 and
> > everything works properly.  Most of them time this can be accomplished
> > by moving things into the explicit "obj-y" objects in
> > net/ipv6/Makefile
> 
> One quick solution is just linking mcast.o statically, because it is not
> easy to separate core functions from mcast.c like addrconf_core.c.
> 
> > 
> > If you are adding stateful dependencies upon ipv6 (you want to inspect
> > the ipv6 routes or something like that), I'm sorry but I really don't
> > want any hard dependies on ipv6's internal state, we can't export that
> > properly.
> 
> I don't think we need that.
> 
After several tries, I think it is not easy to do at all, it relies on
some icmp functions at least, which are still compiled as a module. So,
I can't think out any easier solution than simply adding Kconfig
dependency.
Or maybe I should raise the question again: should we forbid compiling
IPv6 as a module from now on? At least some popular distributions
already use CONFIG_IPV6=y. The only IPv6 things we really need to
compile as a module is probably just procfs/sysfs stuffs.
Thanks.
next prev parent reply	other threads:[~2013-04-23  6:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-21 14:23 [Patch net-next v5 0/5] vxlan: add ipv6 support Cong Wang
2013-04-21 14:23 ` [Patch net-next v5 1/5] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-21 14:23 ` [Patch net-next v5 2/5] ipv6: export ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-21 14:23 ` [Patch net-next v5 3/5] ipv6: export in6addr_loopback to modules Cong Wang
2013-04-21 14:23 ` [Patch net-next v5 4/5] vxlan: add ipv6 support Cong Wang
2013-04-22 12:43   ` David Stevens
2013-04-21 14:23 ` [Patch net-next v5 5/5] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-04-21 19:42 ` [Patch net-next v5 0/5] vxlan: add ipv6 support Stephen Hemminger
2013-04-22 20:08 ` David Miller
2013-04-23  3:30   ` Cong Wang
2013-04-23  6:27     ` Cong Wang [this message]
2013-04-23  6:51       ` Stephen Hemminger
2013-04-23  6:59         ` Cong Wang
2013-04-23  7:05       ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1366698455.21136.11.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).