From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
netdev@vger.kernel.org
Subject: Re: [net-next PATCH 2/3] net: fix enforcing of fragment queue hash list depth
Date: Wed, 24 Apr 2013 08:05:09 -0700 [thread overview]
Message-ID: <1366815909.8964.70.camel@edumazet-glaptop> (raw)
In-Reply-To: <1366810523.26911.495.camel@localhost>
On Wed, 2013-04-24 at 15:35 +0200, Jesper Dangaard Brouer wrote:
> On Fri, 2013-04-19 at 07:49 -0700, Eric Dumazet wrote:
> > Thats pretty irrelevant, memory is limited by the total amount of memory
> > used by fragments, not by hash table size.
> >
> > Its called /proc/sys/net/ipv4/ipfrag_high_thresh
>
>
> I was talking about patch-03, where I do "direct hash cleaning", and
> have moved the mem limit "ipfrag_high_thresh" into the hash cleaning
> step.
I am fine to remove LRU, as maintaining a LRU is too expensive and this
LRU has little purpose.
Old frags are evicted anyway because they have a timer.
We have to keep a global limit, especially if we increase hash table
size, because even with perfect hashing and one frag per hash slot we
might consume too much ram.
We can rename it if you wish but currently this is ipfrag_high_thresh.
next prev parent reply other threads:[~2013-04-24 15:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 21:37 [net-next PATCH 0/3] net: frag code fixes and RFC for LRU removal Jesper Dangaard Brouer
2013-04-18 21:37 ` [net-next PATCH 1/3] net: fix race bug in fragmentation create code Jesper Dangaard Brouer
2013-04-19 1:00 ` Hannes Frederic Sowa
2013-04-19 8:09 ` Jesper Dangaard Brouer
2013-04-18 21:38 ` [net-next PATCH 2/3] net: fix enforcing of fragment queue hash list depth Jesper Dangaard Brouer
2013-04-19 0:52 ` Hannes Frederic Sowa
2013-04-19 10:11 ` Eric Dumazet
2013-04-19 10:41 ` David Laight
2013-04-19 11:14 ` Eric Dumazet
2013-04-19 12:19 ` Jesper Dangaard Brouer
2013-04-19 12:45 ` Hannes Frederic Sowa
2013-04-19 14:29 ` Jesper Dangaard Brouer
2013-04-19 15:06 ` Hannes Frederic Sowa
2013-04-19 19:44 ` Hannes Frederic Sowa
2013-04-22 9:10 ` Jesper Dangaard Brouer
2013-04-22 14:54 ` Hannes Frederic Sowa
2013-04-22 16:30 ` Jesper Dangaard Brouer
2013-04-22 17:49 ` Jesper Dangaard Brouer
2013-04-23 0:20 ` Hannes Frederic Sowa
2013-04-23 14:19 ` Jesper Dangaard Brouer
2013-04-23 20:54 ` Hannes Frederic Sowa
2013-04-19 14:42 ` Eric Dumazet
2013-04-19 14:45 ` Eric Dumazet
2013-04-19 14:45 ` Eric Dumazet
2013-04-19 14:49 ` Eric Dumazet
2013-04-24 13:35 ` Jesper Dangaard Brouer
2013-04-24 15:05 ` Eric Dumazet [this message]
2013-04-18 21:39 ` [RFC net-next PATCH 3/3] net: remove fragmentation LRU list system Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366815909.8964.70.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox