From: Eric Dumazet <eric.dumazet@gmail.com>
To: nicolas.dichtel@6wind.com
Cc: davem@davemloft.net, xiyou.wangcong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/4] sock_diag: do not disclose sock ptr to all users
Date: Thu, 25 Apr 2013 09:57:02 -0700 [thread overview]
Message-ID: <1366909022.8964.166.camel@edumazet-glaptop> (raw)
In-Reply-To: <51795D95.9090904@6wind.com>
On Thu, 2013-04-25 at 18:45 +0200, Nicolas Dichtel wrote:
> I definitely miss the thread about this topic, I will try to find it.
If you think about it, what can possibly the issues ?
Generating a true unique cookie will add a contention point in socket
creation/deletion. [ using an atomic64_t , or idr ]
One possibility was to XOR using a private random (chosen at boot time)
value, but this might be not enough for security guys.
At that time, I decided I was not spending time on this issue.
If you want to do it, make sure you don't respin old stuff and don't
remove existing functionality. Our review time is limited.
Thanks
next prev parent reply other threads:[~2013-04-25 16:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 14:27 [PATCH net-next 0/5] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 1/5] packet_diag: disclose uid value Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 2/5] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 3/5] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-23 15:31 ` Eric Dumazet
2013-04-23 14:27 ` [PATCH net-next 4/5] sock_diag: notify packet socket creation/deletion Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 5/5] sock_diag: notify when filter change Nicolas Dichtel
2013-04-24 8:05 ` Cong Wang
2013-04-24 8:13 ` Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 0/5] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 1/5] packet_diag: disclose uid value Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 2/5] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 3/5] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-24 16:22 ` Eric Dumazet
2013-04-25 5:16 ` David Miller
2013-04-25 8:37 ` Nicolas Dichtel
2013-04-25 9:00 ` David Miller
2013-04-25 13:21 ` [PATCH net-next v3 0/4] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-25 13:21 ` [PATCH net-next v3 1/4] packet_diag: disclose uid value Nicolas Dichtel
2013-04-25 13:21 ` [PATCH net-next v3 2/4] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-25 13:21 ` [PATCH net-next v3 3/4] sock_diag: do not disclose sock ptr to all users Nicolas Dichtel
2013-04-25 15:32 ` Eric Dumazet
2013-04-25 15:36 ` Eric Dumazet
2013-04-25 16:45 ` Nicolas Dichtel
2013-04-25 16:57 ` Eric Dumazet [this message]
2013-04-25 16:53 ` [PATCH net-next v4 0/3] packet_diag: enhance advertised infos Nicolas Dichtel
2013-04-25 16:53 ` [PATCH net-next v4 1/3] packet_diag: disclose uid value Nicolas Dichtel
2013-04-25 16:53 ` [PATCH net-next v4 2/3] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-25 16:53 ` [PATCH net-next v4 3/3] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-29 17:22 ` [PATCH net-next v4 0/3] packet_diag: enhance advertised infos David Miller
2013-04-25 13:21 ` [PATCH net-next v3 4/4] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-25 13:51 ` [PATCH net-next v2 3/5] " Eric Dumazet
2013-04-24 15:52 ` [PATCH net-next v2 4/5] sock_diag: notify packet socket creation/deletion Nicolas Dichtel
2013-05-17 14:25 ` [PATCH net-next v3] " Nicolas Dichtel
2013-05-20 6:29 ` David Miller
2013-05-21 15:14 ` Nicolas Dichtel
2013-05-21 18:43 ` David Miller
2013-05-22 11:49 ` Nicolas Dichtel
2013-04-24 15:52 ` [PATCH net-next v2 5/5] sock_diag: notify when filter change Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366909022.8964.166.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox