Re: [PATCH v3 2/3] unix/dgram: fix peeking with an offset larger than data in queue

Eric Dumazet
2013-04-30T00:49:54Z

On Mon, 2013-04-29 at 17:42 -0400, Benjamin Poirier wrote:
> Currently, peeking on a unix datagram socket with an offset larger than len of
> the data in the sk receive queue returns immediately with bogus data. That's
> because *off is not reset between each skb_queue_walk().
>
> This patch fixes this so that the behavior is the same as peeking with no
> offset on an empty queue: the caller blocks.
>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
>
> ---
>
> v2: address review feedback from Eric Dumazet
>
> v3: address review feedback from Cong Wang
>
> net/core/datagram.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)

Acked-by: Eric Dumazet <edumazet@google.com>