From: Lucas Stach <l.stach@pengutronix.de>
To: Frank Li <lznuaa@gmail.com>
Cc: Robert Schwebel <r.schwebel@pengutronix.de>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call"
Date: Mon, 29 Apr 2013 15:46:57 +0200 [thread overview]
Message-ID: <1367243217.4100.13.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <CAHrpEqSi+caO5gSo1BZRGqytxhCOs-OuyjiCaG+7fnsnFBj77g@mail.gmail.com>
Am Samstag, den 27.04.2013, 18:26 +0800 schrieb Frank Li:
> >
> > - remove locking in a way that memory is freed which is in use
>
> The purpose of remove lock is that fix dead lock.
Could you please elaborate? What is the exact situation which caused a
deadlock here? I tried to see what's happening from your changelogs, but
I'm not sure I can follow here. Wasn't the problem more of the used
spinlocks not being IRQ-save and thus potentially creating a deadlock?
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-04-29 13:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 8:52 [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call" Lucas Stach
2013-04-26 8:52 ` [PATCH resend 2/3] Revert "net: fec: put tx to napi poll function to fix dead lock" Lucas Stach
2013-04-26 8:52 ` [PATCH resend 3/3] Revert "net: fec: add napi support to improve proformance" Lucas Stach
2013-04-26 9:32 ` [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call" Frank Li
2013-04-26 13:44 ` Robert Schwebel
2013-04-26 18:33 ` David Miller
2013-04-27 9:05 ` Robert Schwebel
2013-04-27 10:26 ` Frank Li
2013-04-27 12:06 ` Francois Romieu
2013-04-27 12:43 ` Frank Li
2013-04-27 19:16 ` Francois Romieu
2013-04-28 3:09 ` Frank Li
2013-04-28 4:31 ` Frank Li
2013-04-28 9:40 ` Francois Romieu
2013-04-28 10:03 ` Frank Li
2013-04-28 9:39 ` Francois Romieu
2013-04-28 10:05 ` Frank Li
2013-04-28 17:57 ` Francois Romieu
2013-04-28 23:45 ` Frank Li
2013-04-29 13:46 ` Lucas Stach [this message]
2013-05-02 1:51 ` Frank Li
2013-04-28 5:11 ` David Miller
2013-04-28 17:27 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367243217.4100.13.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=r.schwebel@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).