* [PATCH net-next] net: Use consume_skb() to free gso segmented skb
@ 2013-04-29 23:02 Sridhar Samudrala
2013-04-30 0:33 ` Eric Dumazet
2013-04-30 4:18 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sridhar Samudrala @ 2013-04-29 23:02 UTC (permalink / raw)
To: davem; +Cc: netdev
Use consume_skb() to free the original skb that is successfully transmitted
as gso segmented skbs so that it is not treated as a drop due to an error.
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
---
diff --git a/net/core/dev.c b/net/core/dev.c
index 7c30dce..4040673 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2565,8 +2565,11 @@ gso:
} while (skb->next);
out_kfree_gso_skb:
- if (likely(skb->next == NULL))
+ if (likely(skb->next == NULL)) {
skb->destructor = DEV_GSO_CB(skb)->destructor;
+ consume_skb(skb);
+ return rc;
+ }
out_kfree_skb:
kfree_skb(skb);
out:
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: Use consume_skb() to free gso segmented skb
2013-04-29 23:02 [PATCH net-next] net: Use consume_skb() to free gso segmented skb Sridhar Samudrala
@ 2013-04-30 0:33 ` Eric Dumazet
2013-04-30 4:18 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2013-04-30 0:33 UTC (permalink / raw)
To: Sridhar Samudrala; +Cc: davem, netdev
On Mon, 2013-04-29 at 16:02 -0700, Sridhar Samudrala wrote:
> Use consume_skb() to free the original skb that is successfully transmitted
> as gso segmented skbs so that it is not treated as a drop due to an error.
>
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
> ---
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 7c30dce..4040673 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2565,8 +2565,11 @@ gso:
> } while (skb->next);
>
> out_kfree_gso_skb:
> - if (likely(skb->next == NULL))
> + if (likely(skb->next == NULL)) {
> skb->destructor = DEV_GSO_CB(skb)->destructor;
> + consume_skb(skb);
> + return rc;
> + }
> out_kfree_skb:
> kfree_skb(skb);
> out:
>
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: Use consume_skb() to free gso segmented skb
2013-04-29 23:02 [PATCH net-next] net: Use consume_skb() to free gso segmented skb Sridhar Samudrala
2013-04-30 0:33 ` Eric Dumazet
@ 2013-04-30 4:18 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-04-30 4:18 UTC (permalink / raw)
To: sri; +Cc: netdev
From: Sridhar Samudrala <sri@us.ibm.com>
Date: Mon, 29 Apr 2013 16:02:42 -0700
> Use consume_skb() to free the original skb that is successfully transmitted
> as gso segmented skbs so that it is not treated as a drop due to an error.
>
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-30 4:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29 23:02 [PATCH net-next] net: Use consume_skb() to free gso segmented skb Sridhar Samudrala
2013-04-30 0:33 ` Eric Dumazet
2013-04-30 4:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).