Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: Use consume_skb() to free gso segmented skb
Date: Mon, 29 Apr 2013 17:33:42 -0700	[thread overview]
Message-ID: <1367282022.8964.333.camel@edumazet-glaptop> (raw)
In-Reply-To: <1367276562.23068.7.camel@sridhar.usor.ibm.com>

On Mon, 2013-04-29 at 16:02 -0700, Sridhar Samudrala wrote:
> Use consume_skb() to free the original skb that is successfully transmitted 
> as gso segmented skbs so that it is not treated as a drop due to an error.
> 
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
> ---
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 7c30dce..4040673 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2565,8 +2565,11 @@ gso:
>  	} while (skb->next);
>  
>  out_kfree_gso_skb:
> -	if (likely(skb->next == NULL))
> +	if (likely(skb->next == NULL)) {
>  		skb->destructor = DEV_GSO_CB(skb)->destructor;
> +		consume_skb(skb);
> +		return rc;
> +	}
>  out_kfree_skb:
>  	kfree_skb(skb);
>  out:
> 

Acked-by: Eric Dumazet <edumazet@google.com>

  reply	other threads:[~2013-04-30  0:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 23:02 [PATCH net-next] net: Use consume_skb() to free gso segmented skb Sridhar Samudrala
2013-04-30  0:33 ` Eric Dumazet [this message]
2013-04-30  4:18 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367282022.8964.333.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox