From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v3 1/3] unix/dgram: peek beyond 0-sized skbs Date: Mon, 29 Apr 2013 17:48:20 -0700 Message-ID: <1367282900.8964.334.camel@edumazet-glaptop> References: <1367271734-14379-1-git-send-email-bpoirier@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Eric Dumazet , Pavel Emelyanov , Cong Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Benjamin Poirier Return-path: In-Reply-To: <1367271734-14379-1-git-send-email-bpoirier@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2013-04-29 at 17:42 -0400, Benjamin Poirier wrote: > "77c1090 net: fix infinite loop in __skb_recv_datagram()" (v3.8) introduced a > regression: > After that commit, recv can no longer peek beyond a 0-sized skb in the queue. > __skb_recv_datagram() instead stops at the first skb with len == 0 and results > in the system call failing with -EFAULT via skb_copy_datagram_iovec(). > > When peeking at an offset with 0-sized skb(s), each one of those is received > only once, in sequence. The offset starts moving forward again after receiving > datagrams with len > 0. > > Signed-off-by: Benjamin Poirier > > --- Acked-by: Eric Dumazet