From: Cong Wang <amwang@redhat.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
Adam Baker <linux@baker-net.org.uk>
Subject: Re: [Patch net-next v3 2/3] bridge: only expire the mdb entry when query is received
Date: Fri, 03 May 2013 11:50:22 +0800 [thread overview]
Message-ID: <1367553022.2415.55.camel@cr0> (raw)
In-Reply-To: <20130502015938.GA2237@gondor.apana.org.au>
On Thu, 2013-05-02 at 09:59 +0800, Herbert Xu wrote:
> On Tue, Apr 30, 2013 at 03:10:18PM +0800, Cong Wang wrote:
> >
> > @@ -1275,7 +1277,7 @@ static void br_multicast_leave_group(struct net_bridge *br,
> > br->multicast_last_member_interval;
> >
> > if (!port) {
> > - if (mp->mglist &&
> > + if (mp->mglist && mp->timer_armed &&
> > (timer_pending(&mp->timer) ?
> > time_after(mp->timer.expires, time) :
> > try_to_del_timer_sync(&mp->timer) >= 0)) {
>
> This whole section of code should now be removed since we're now
> only arming the timer in response to a query to that group. Of
> course if we were the querier and sent out a query here then you'd
> need to simulate the reception of a query.
Hmm, this piece of code is checking if bridge itself is in the mdb entry
and if it just receives a leave, which seems still necessary... What am
I missing?
Thanks!
next prev parent reply other threads:[~2013-05-03 3:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 7:10 [Patch net-next v3 1/3] bridge: select IP addr as source addr for querier Cong Wang
2013-04-30 7:10 ` [Patch net-next v3 2/3] bridge: only expire the mdb entry when query is received Cong Wang
2013-05-02 1:59 ` Herbert Xu
2013-05-03 3:50 ` Cong Wang [this message]
2013-05-03 4:01 ` Herbert Xu
2013-05-03 7:08 ` Cong Wang
2013-05-03 9:30 ` Herbert Xu
2013-05-06 3:24 ` Cong Wang
2013-05-09 5:15 ` Herbert Xu
2013-05-09 12:53 ` Cong Wang
2013-05-10 3:21 ` Herbert Xu
2013-04-30 7:10 ` [Patch net-next v3 3/3] bridge: send query as soon as leave " Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367553022.2415.55.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux@baker-net.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox