RE: [PATCH v2 net-next] af_unix: fix a fatal race with bit fields

David Laight
2013-05-01T15:55:40Z

> diff --git a/include/net/af_unix.h b/include/net/af_unix.h
> index a8836e8..dbdfd2b 100644
> --- a/include/net/af_unix.h
> +++ b/include/net/af_unix.h
> @@ -57,9 +57,10 @@ struct unix_sock {
> struct list_head link;
> atomic_long_t inflight;
> spinlock_t lock;
> - unsigned int gc_candidate : 1;
> - unsigned int gc_maybe_cycle : 1;
> unsigned char recursion_level;
> + unsigned long gc_flags;
> +#define UNIX_GC_CANDIDATE 0
> +#define UNIX_GC_MAYBE_CYCLE 1
> struct socket_wq peer_wq;
> };

Why not just change gc_candidate and gc_maybe_cycle to
unsigned char?
It might reduce the number of pad bytes somewhat.

David