From: Dan Williams <dcbw@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: dagofthedofg@gmail.com, bjorn@mork.no, netdev@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] qmi_wwan/cdc_ether: add device IDs for Dell 5804 (Novatel E371) WWAN card
Date: Wed, 08 May 2013 14:25:50 -0500 [thread overview]
Message-ID: <1368041150.1664.22.camel@dcbw.foobar.com> (raw)
In-Reply-To: <20130508.121922.553557463648781118.davem@davemloft.net>
On Wed, 2013-05-08 at 12:19 -0700, David Miller wrote:
> From: dag dg <dagofthedofg@gmail.com>
> Date: Wed, 8 May 2013 14:11:48 -0500
>
> > Just a side note on this. By default for this device, modprobe won't
> > load and assign the option driver. However, if cdc_ether is
> > blacklisted and you try to load option onto the device, it will try to
> > load the option driver onto where cdc_ether was being used, which will
> > cause the system to lock up. I'm not sure what needs to be done to
> > force qmi_wwan to take over cdc_ether without option grabbing these
> > IDs...
This is a consequence of "new_id" not being flexible enough to handle
class/subclass/protocol in addition to USB IDs. Thus when you use it,
the driver binds to *all* USB interfaces, even ones that the driver
shouldn't ever control
So the issue you refer to is actually user error, helped by a
too-coarse-grained kernel API. It's not an issue when things are all
done correctly, which is to say when the USB IDs and interface
class/subclass/protocol are properly added to the kernel drivers.
The option patch I posted earlier will fix this issue correctly.
Dan
next prev parent reply other threads:[~2013-05-08 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 21:14 qmi_wwan/cdc_ether: add device IDs for Dell 5804 (Novatel E371) WWAN card Dan Williams
2013-05-06 21:17 ` [PATCH] " Dan Williams
2013-05-06 21:22 ` Bjørn Mork
2013-05-08 19:08 ` David Miller
2013-05-08 19:11 ` dag dg
2013-05-08 19:19 ` David Miller
2013-05-08 19:25 ` Dan Williams [this message]
2013-05-08 19:27 ` dag dg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368041150.1664.22.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=bjorn@mork.no \
--cc=dagofthedofg@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox