From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: conntrack: remove the central spinlock
Date: Wed, 08 May 2013 23:01:41 -0700 [thread overview]
Message-ID: <1368079301.13473.88.camel@edumazet-glaptop> (raw)
In-Reply-To: <kmfd2s$e2m$1@ger.gmane.org>
On Thu, 2013-05-09 at 05:43 +0000, Cong Wang wrote:
> On Thu, 09 May 2013 at 03:04 GMT, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> > +#if 0
> > + for (i = 0; i < ARRAY_SIZE(nf_conntrack_locks); i++)
> > + arch_spin_lock_init(&nf_conntrack_locks[i]);
> > +#endif
> > +
>
> Is this intentional?
What do you think ?
Apparently arch_spin_lock_init() does not exist (but for ia64)
kernel/lglock.c simply relies on storage being cleared.
nf_conntrack_locks[] being cleared, we do not have to init it.
But I do not really like this.
next prev parent reply other threads:[~2013-05-09 6:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 3:04 [PATCH nf-next] netfilter: conntrack: remove the central spinlock Eric Dumazet
2013-05-09 5:43 ` Cong Wang
2013-05-09 6:01 ` Eric Dumazet [this message]
2013-05-09 7:46 ` Cong Wang
2013-05-09 13:46 ` Eric Dumazet
2013-05-22 17:47 ` [PATCH v2 " Eric Dumazet
2013-05-22 18:20 ` Joe Perches
2013-05-22 19:26 ` Eric Dumazet
2013-05-22 19:57 ` Joe Perches
2013-05-22 20:16 ` Eric Dumazet
2013-05-22 20:38 ` Joe Perches
2013-05-22 20:48 ` Eric Dumazet
2013-05-22 21:12 ` Joe Perches
2013-05-22 21:29 ` David Miller
2013-05-22 21:34 ` Eric Dumazet
2013-05-24 13:16 ` Jesper Dangaard Brouer
2013-05-24 13:51 ` Eric Dumazet
2013-05-27 12:33 ` Jesper Dangaard Brouer
2013-05-27 12:36 ` Pablo Neira Ayuso
2013-08-23 14:42 ` Jesper Dangaard Brouer
2013-08-26 22:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368079301.13473.88.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox