netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shahed Shaikh <shahed.shaikh@qlogic.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Dept_NX_Linux_NIC_Driver@qlogic.com>,
	Rajesh Borundia <rajesh.borundia@qlogic.com>
Subject: [PATCH net v2 8/8] qlcnic: Fix validation of link event command.
Date: Thu, 9 May 2013 15:25:16 -0400	[thread overview]
Message-ID: <1368127516-9943-9-git-send-email-shahed.shaikh@qlogic.com> (raw)
In-Reply-To: <1368127516-9943-1-git-send-email-shahed.shaikh@qlogic.com>

From: Rajesh Borundia <rajesh.borundia@qlogic.com>

o VF driver that has enabled asynchronous link events
  may not set BIT_8 in the request, if it does not require
  link state in the response.

Signed-off-by: Pratik Pujar <pratik.pujar@qlogic.com>
Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
---
 .../net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c   |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c
index c81be2d..1a66ccd 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c
@@ -1133,9 +1133,6 @@ static int qlcnic_sriov_validate_linkevent(struct qlcnic_vf_info *vf,
 	if ((cmd->req.arg[1] >> 16) != vf->rx_ctx_id)
 		return -EINVAL;
 
-	if (!(cmd->req.arg[1] & BIT_8))
-		return -EINVAL;
-
 	return 0;
 }
 
-- 
1.5.6

  parent reply	other threads:[~2013-05-09 19:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 19:25 [PATCH net v2 0/8] qlcnic: Bug fixes Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 1/8] qlcnic: Fix setting MAC address Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 2/8] qlcnic: Fix ethtool strings Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 3/8] qlcnic: Fix missing bracket in module parameter Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 4/8] qlcnic: Fix ethtool supported port status for 83xx Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 5/8] qlcnic: Fix reset recovery after transmit timeout Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 6/8] qlcnic: Fix bug in diagnostics test reset recovery path Shahed Shaikh
2013-05-09 19:25 ` [PATCH net v2 7/8] qlcnic: Fix mailbox response handling Shahed Shaikh
2013-05-09 19:25 ` Shahed Shaikh [this message]
2013-05-11 23:01 ` [PATCH net v2 0/8] qlcnic: Bug fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368127516-9943-9-git-send-email-shahed.shaikh@qlogic.com \
    --to=shahed.shaikh@qlogic.com \
    --cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rajesh.borundia@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).