From: Matthew Garrett <matthew.garrett@nebula.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Emmanuel Grumbach <egrumbach@gmail.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
Roman Yepishev <roman.yepishev@gmail.com>,
"Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
Mike Miller <mike.miller@hp.com>,
"iss_storagedev@hp.com" <iss_storagedev@hp.com>,
Guo-Fu Tseng <cooldavid@cooldavid.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Francois Romieu <romieu@fr.zoreil.com>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"aacraid@adaptec.com" <aacraid@adaptec.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: is L1 really disabled in iwlwifi
Date: Sat, 11 May 2013 20:22:11 +0000 [thread overview]
Message-ID: <1368303730.2425.47.camel@x230> (raw)
In-Reply-To: <1725435.3DlCxYF2FV@vostro.rjw.lan>
On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote:
> On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote:
> > I propose the following patch. Any comments?
>
> In my opinion this is dangerous, because it opens us to bugs that right now
> are prevented from happening due to the way the code works.
Right, I'm also not entirely comfortable with this. The current
behaviour may be confusing, but we could reduce that by renaming the
functions. I'm still not clear on whether anyone's actually seeing
problems caused by the existing behaviour.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-05-11 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANUX_P2Hy02SnyYS24dyUGLv3wB3L5xkXt8Y1s+8_RG9d5ReAw@mail.gmail.com>
[not found] ` <CANUX_P3znXgMN5aBZbEVx_zKpTQ98my1C_cBG5+mERFWrrrLEw@mail.gmail.com>
[not found] ` <CANUX_P3Mt3X8JXq5siSijrWGkjeWbTCcdmJ-Fuv6U8jUqrFouQ@mail.gmail.com>
[not found] ` <CAErSpo66=UngrHNcEDeh4gXnt5c0qJHwbxum0mBz-rSWGduLhg@mail.gmail.com>
[not found] ` <CANUX_P0hpx8NNvX6cJXfOZMNYN8hrEF-gzf9hBN2Uz=k0WiwgA@mail.gmail.com>
[not found] ` <CANUX_P1JnFk7yovC7kXBMDWiErGhvzDQrNCm8te39m41SonCNg@mail.gmail.com>
[not found] ` <CAErSpo5WbdCx0iyt14bJxCiNBtUWjT2rMeg5YwNQaRt=M+_v8Q@mail.gmail.com>
[not found] ` <1367362536.9976.9.camel@x230>
[not found] ` <CANUX_P1sS8+3s-8-TyovHEwpa5qgQDj4W8P_hvfQjE2MKcTNEA@mail.gmail.com>
[not found] ` <CAErSpo6OCyTy19u6Xaf=xr0TSDriwCD3n-oMc7eJyLzuJ9d60g@mail.gmail.com>
[not found] ` <CAErSpo6OCyTy19u6Xaf=xr0TSDriwCD3n-oMc7eJyLzuJ9d60g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-10 22:52 ` is L1 really disabled in iwlwifi Bjorn Helgaas
[not found] ` <20130510225257.GA10847-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2013-05-11 20:26 ` Rafael J. Wysocki
2013-05-11 20:22 ` Matthew Garrett [this message]
2013-05-16 22:55 ` Bjorn Helgaas
2013-05-17 5:49 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368303730.2425.47.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=aacraid@adaptec.com \
--cc=bhelgaas@google.com \
--cc=cooldavid@cooldavid.org \
--cc=egrumbach@gmail.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mike.miller@hp.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=rjw@sisk.pl \
--cc=roman.yepishev@gmail.com \
--cc=romieu@fr.zoreil.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).