* [PATCH 1/2] net/usb: r8152: Remove redundant version.h header inclusion
@ 2013-05-13 4:55 Sachin Kamat
2013-05-13 4:55 ` [PATCH 2/2] net/usb: r8152: Use module_usb_driver() Sachin Kamat
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-05-13 4:55 UTC (permalink / raw)
To: netdev; +Cc: nic_swsd, hayeswang, davem, sachin.kamat
version.h header inclusion is not necessary as detected by
checkversion.pl.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
This series compile tested against linux-next (20130513).
---
drivers/net/usb/r8152.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 14e5198..8e53e41 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -11,7 +11,6 @@
#include <linux/signal.h>
#include <linux/slab.h>
#include <linux/module.h>
-#include <linux/version.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <linux/mii.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] net/usb: r8152: Use module_usb_driver()
2013-05-13 4:55 [PATCH 1/2] net/usb: r8152: Remove redundant version.h header inclusion Sachin Kamat
@ 2013-05-13 4:55 ` Sachin Kamat
0 siblings, 0 replies; 2+ messages in thread
From: Sachin Kamat @ 2013-05-13 4:55 UTC (permalink / raw)
To: netdev; +Cc: nic_swsd, hayeswang, davem, sachin.kamat
module_usb_driver() eliminates boilerplate and simplifies the code.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/net/usb/r8152.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 8e53e41..d02bac8 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1748,18 +1748,7 @@ static struct usb_driver rtl8152_driver = {
.resume = rtl8152_resume
};
-static int __init usb_rtl8152_init(void)
-{
- return usb_register(&rtl8152_driver);
-}
-
-static void __exit usb_rtl8152_exit(void)
-{
- usb_deregister(&rtl8152_driver);
-}
-
-module_init(usb_rtl8152_init);
-module_exit(usb_rtl8152_exit);
+module_usb_driver(rtl8152_driver);
MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-13 5:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-13 4:55 [PATCH 1/2] net/usb: r8152: Remove redundant version.h header inclusion Sachin Kamat
2013-05-13 4:55 ` [PATCH 2/2] net/usb: r8152: Use module_usb_driver() Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).