From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Denys Fedoryshchenko <denys@visp.net.lb>,
David Ward <david.ward@ll.mit.edu>,
hayeswang <hayeswang@realtek.com>,
Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/802/mrp: fix lockdep splat
Date: Tue, 14 May 2013 09:12:20 +0800 [thread overview]
Message-ID: <1368493940.30953.3.camel@cr0> (raw)
In-Reply-To: <1368447851.13473.119.camel@edumazet-glaptop>
On Mon, 2013-05-13 at 05:24 -0700, Eric Dumazet wrote:
> del_timer_sync(&app->join_timer);
>
> - spin_lock(&app->lock);
> + spin_lock_bh(&app->lock);
But we just have removed the join timer before taking this spin lock, so
it is not possible to race with timer, but we still have race condition
with mrp_rcv() which is called in BH context too. However, this is not
what Denys reported, so I have no idea on this.
next prev parent reply other threads:[~2013-05-14 1:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 11:59 r8169 not working under latest kernels Denys Fedoryshchenko
2013-05-13 12:24 ` [PATCH] net/802/mrp: fix lockdep splat Eric Dumazet
2013-05-13 12:53 ` Denys Fedoryshchenko
2013-05-14 19:07 ` David Miller
2013-05-14 19:21 ` Eric Dumazet
2013-05-14 19:40 ` Eric Dumazet
2013-05-14 20:03 ` David Miller
2013-05-15 14:50 ` Denys Fedoryshchenko
2013-05-15 15:22 ` Eric Dumazet
2013-05-15 16:34 ` Ward, David - 0663 - MITLL
2013-05-15 16:41 ` Ward, David - 0663 - MITLL
2013-05-14 20:01 ` Denys Fedoryshchenko
2013-05-14 1:12 ` Cong Wang [this message]
2013-05-14 1:30 ` Eric Dumazet
2013-05-15 20:00 ` r8169 not working under latest kernels Denys Fedoryshchenko
2013-05-16 22:57 ` Francois Romieu
2013-05-17 8:15 ` Denys Fedoryshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368493940.30953.3.camel@cr0 \
--to=amwang@redhat.com \
--cc=david.ward@ll.mit.edu \
--cc=denys@visp.net.lb \
--cc=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).