Re: [PATCH] net: ipv6: Add IPv6 support to the ping socket.

[Eric Dumazet <eric.dumazet@gmail.com>]

On Tue, 2013-05-14 at 23:58 +0900, Lorenzo Colitti wrote:
> This adds the ability to send ICMPv6 echo requests without a
> raw socket. The equivalent ability for ICMPv4 was added in
> 2011.
> 
> Instead of having separate code paths for IPv4 and IPv6, make
> most of the code in net/ipv4/ping.c dual-stack and only add a
> few IPv6-specific bits (like the protocol definition) to a new
> net/ipv6/ping.c. Hopefully this will reduce divergence and/or
> duplication of bugs in the future.
> 

Interesting, but :

> +#ifdef CONFIG_IPV6
> +#include <linux/in6.h>
> +#include <linux/icmpv6.h>
> +#include <net/addrconf.h>
> +#include <net/ipv6.h>
> +#include <net/transp_v6.h>
> +#endif
>  

This cannot possibly work with
CONFIG_IPV6=m

Please always compile/test your IPv6 patches with following possible
configurations.

1) CONFIG_IPV6=m
2) CONFIG_IPV6=y
3) # CONFIG_IPV6 is not set

Thanks !