Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Michael Chan <mchan@broadcom.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
	Nithin Nayak Sujir <nsujir@broadcom.com>,
	davem@davemloft.net, netdev@vger.kernel.org,
	stable@vger.kernel.org
Subject: RE: [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO
Date: Tue, 14 May 2013 09:46:10 -0700	[thread overview]
Message-ID: <1368549970.4519.16.camel@edumazet-glaptop> (raw)
In-Reply-To: <1368548345.12268.76.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>

On Tue, 2013-05-14 at 09:19 -0700, Michael Chan wrote:

> We relocate once and then drop the packet if we encounter additional
> errors, including OOM, DMA mapping error, 4G boundary, etc.  The new
> linear skb should not hit the 4G boundary again.  The room between the
> end of this current buffer and 4G isn't big enough for the new linear
> skb.

This remind me an issue on bnx2x :

bnx2x FW has a limitation on GSO packets :
    
A single mss can not span more than 10 fragments.

After "net: use a per task frag allocator" patch, its possible
for an application interleaving small write() on several sockets
to build pathological skbs using 16 fragments (aka MAX_SKB_FRAGS)
but small amount of payload.
    
Fast path should build skbs with 2 or 3 fragments, as fragments
can be order-3 pages.
    
bnx2x driver performs an expensive skb_linearize() call and
this can fail if memory is fragmented : skb->len can be around 64K,
and including the skb_shared_info overhead, we might need order-5
pages.

  reply	other threads:[~2013-05-14 16:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 21:04 [PATCH v2 net 0/2] tg3: 2 bugfixes - TSO data corruption and phy power down Nithin Nayak Sujir
2013-05-13 21:04 ` [PATCH v2 net 1/2] tg3: Skip powering down function 0 on certain serdes devices Nithin Nayak Sujir
2013-05-14 18:08   ` Joe Perches
2013-05-14 18:17     ` Nithin Nayak Sujir
2013-05-13 21:04 ` [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO Nithin Nayak Sujir
2013-05-13 21:14   ` Eric Dumazet
2013-05-13 21:34     ` Nithin Nayak Sujir
2013-05-13 21:40       ` Eric Dumazet
2013-05-13 21:47         ` Nithin Nayak Sujir
2013-05-13 22:10           ` Eric Dumazet
2013-05-14  8:40           ` David Laight
2013-05-14 15:04             ` Michael Chan
2013-05-14 15:20               ` David Laight
2013-05-14 16:19                 ` Michael Chan
2013-05-14 16:46                   ` Eric Dumazet [this message]
2013-05-15  8:56                   ` David Laight
2013-05-15 15:12                     ` Michael Chan
2013-05-15 15:23                       ` Eric Dumazet
2013-05-15 15:51                         ` Michael Chan
2013-05-14 18:32 ` [PATCH v2 net 0/2] tg3: 2 bugfixes - TSO data corruption and phy power down David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368549970.4519.16.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=nsujir@broadcom.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox