From: Joe Perches <joe@perches.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 13/33] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource
Date: Thu, 16 May 2013 08:37:15 -0700 [thread overview]
Message-ID: <1368718635.2194.55.camel@joe-AO722> (raw)
In-Reply-To: <1368702961-4325-14-git-send-email-wsa@the-dreams.de>
On Thu, 2013-05-16 at 13:15 +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
[]
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
[]
> @@ -2745,11 +2745,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
> if (mdp->cd->tsu) {
> struct resource *rtsu;
> rtsu = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - if (!rtsu) {
> - dev_err(&pdev->dev, "Not found TSU resource\n");
> - ret = -ENODEV;
> - goto out_release;
> - }
> mdp->tsu_addr = devm_ioremap_resource(&pdev->dev, rtsu);
> if (IS_ERR(mdp->tsu_addr)) {
> ret = PTR_ERR(mdp->tsu_addr);
I'm not sure it matters, but at least one of these
conversions will now return -EINVAL instead of -ENODEV
next prev parent reply other threads:[~2013-05-16 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 11:15 [PATCH 00/33] devm improvement series, part 1, take 2 Wolfram Sang
2013-05-16 11:15 ` [PATCH 13/33] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource Wolfram Sang
2013-05-16 15:37 ` Joe Perches [this message]
2013-05-16 11:57 ` [PATCH 00/33] devm improvement series, part 1, take 2 Artem Bityutskiy
2013-05-16 12:55 ` Viresh Kumar
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 16:13 ` Wolfram Sang
2013-05-16 18:29 ` Stephen Warren
2013-05-23 20:32 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368718635.2194.55.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox