netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>, Cong Wang <amwang@redhat.com>
Subject: [Patch net-next v8 07/11] vxlan: respect disable_ipv6 sysctl
Date: Fri, 17 May 2013 08:21:35 +0800	[thread overview]
Message-ID: <1368750099-14086-8-git-send-email-amwang@redhat.com> (raw)
In-Reply-To: <1368750099-14086-1-git-send-email-amwang@redhat.com>

From: Cong Wang <amwang@redhat.com>

When disable_ipv6 is set, we should not allow IPv6 vxlan
device created on top of it.

Cc: David Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
 drivers/net/vxlan.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 46c59a6..1ee79e0 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -1681,6 +1681,7 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
 	struct vxlan_rdst *dst = &vxlan->default_dst;
 	__u32 vni;
 	int err;
+	bool use_ipv6 = false;
 
 	if (!data[IFLA_VXLAN_ID])
 		return -EINVAL;
@@ -1703,6 +1704,7 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
 		nla_memcpy(&dst->remote_ip.sin6.sin6_addr, data[IFLA_VXLAN_GROUP6],
 			   sizeof(struct in6_addr));
 		dst->remote_ip.sa.sa_family = AF_INET6;
+		use_ipv6 = true;
 #else
 		return -EPFNOSUPPORT;
 #endif
@@ -1719,6 +1721,7 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
 		nla_memcpy(&vxlan->saddr.sin6.sin6_addr, data[IFLA_VXLAN_LOCAL6],
 			   sizeof(struct in6_addr));
 		vxlan->saddr.sa.sa_family = AF_INET6;
+		use_ipv6 = true;
 #else
 		return -EPFNOSUPPORT;
 #endif
@@ -1734,6 +1737,17 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
 			return -ENODEV;
 		}
 
+#if IS_ENABLED(CONFIG_IPV6)
+		if (use_ipv6) {
+			struct inet6_dev *idev = in6_dev_get(lowerdev);
+			if (idev && idev->cnf.disable_ipv6) {
+				pr_info("IPv6 is disabled via sysctl\n");
+				return -EPERM;
+			}
+		}
+#else
+		BUG_ON(use_ipv6);
+#endif
 		if (!tb[IFLA_MTU])
 			dev->mtu = lowerdev->mtu - VXLAN_HEADROOM;
 
-- 
1.7.7.6

  parent reply	other threads:[~2013-05-17  0:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  0:21 [Patch net-next v8 00/11] vxlan: add ipv6 support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 01/11] vxlan: defer vxlan init as late as possible Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 02/11] ipv6: make ip6_dst_hoplimit() static inline Cong Wang
2013-05-17 13:02   ` Sergei Shtylyov
2013-05-17 21:13   ` David Miller
2013-05-22  4:54     ` Cong Wang
2013-05-22  7:14       ` David Miller
2013-05-22 10:28         ` Cong Wang
2013-05-22 15:50           ` Mike Rapoport
2013-05-22 16:03             ` Cong Wang
2013-05-22 16:10               ` Mike Rapoport
2013-05-24  5:10                 ` Cong Wang
2013-05-24  5:15                 ` Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 03/11] ipv6: move ip6_local_out into core kernel Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 04/11] ipv6: export a stub for IPv6 symbols used by vxlan Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 05/11] ipv6: export in6addr_loopback to modules Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 06/11] vxlan: add ipv6 support Cong Wang
2013-05-17  0:21 ` Cong Wang [this message]
2013-05-17 13:07   ` [Patch net-next v8 07/11] vxlan: respect disable_ipv6 sysctl Sergei Shtylyov
2013-05-17  0:21 ` [Patch net-next v8 08/11] vxlan: add ipv6 route short circuit support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 09/11] vxlan: add ipv6 proxy support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 10/11] vxlan: respect scope_id for ll addr Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 11/11] ipv6: Add generic UDP Tunnel segmentation Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368750099-14086-8-git-send-email-amwang@redhat.com \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).