From: Cong Wang <amwang@redhat.com>
To: netdev@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
Adam Baker <linux@baker-net.org.uk>
Subject: Re: [Patch net-next v4 1/3] bridge: use the bridge IP addr as source addr for querier
Date: Fri, 17 May 2013 10:08:32 +0800 [thread overview]
Message-ID: <1368756512.3453.18.camel@cr0> (raw)
In-Reply-To: <1368755965-26615-1-git-send-email-amwang@redhat.com>
On Fri, 2013-05-17 at 09:59 +0800, Cong Wang wrote:
> +static DEVICE_ATTR(multicast_query_zero_source, S_IRUGO | S_IWUSR,
> + show_multicast_query_zero_source,
> + store_multicast_query_zero_source);
The file name seems ugly, I just noticed there is already a similar one
for ICMP: icmp_errors_use_inbound_ifaddr, so I think
'multicast_query_use_ifaddr' should be better than
'multicast_query_zero_source'.
prev parent reply other threads:[~2013-05-17 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 1:59 [Patch net-next v4 1/3] bridge: use the bridge IP addr as source addr for querier Cong Wang
2013-05-17 1:59 ` [Patch net-next v4 2/3] bridge: only expire the mdb entry when query is received Cong Wang
2013-05-17 1:59 ` [Patch net-next v4 3/3] bridge: send query as soon as leave " Cong Wang
2013-05-17 2:08 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368756512.3453.18.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux@baker-net.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).