From: Eric Dumazet <eric.dumazet@gmail.com>
To: "govindarajulu.v" <govindarajulu90@gmail.com>
Cc: davem@davemloft.net, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: netdev_pick_tx: use get_xps_q if xps map is set
Date: Fri, 17 May 2013 06:35:33 -0700 [thread overview]
Message-ID: <1368797733.3301.84.camel@edumazet-glaptop> (raw)
In-Reply-To: <1368780528-15209-1-git-send-email-govindarajulu90@gmail.com>
On Fri, 2013-05-17 at 14:18 +0530, govindarajulu.v wrote:
> From: "govindarajulu.v" <govindarajulu90@gmail.com>
>
> netdev_pick_tx ignores the xps map configuration if netdev->ndo_select_queue
> is defined. Most of the drivers define ndo_select_queue. The problem with this
> is, if admin wants kernel to pick tx queue based on xps map (instead of driver
> defined ndo_select_queue), he has to netdev->ndo_select_queue = NULL, compile
> and reload.
>
> This patch fixes it by checking if dev->xps_maps is defined. If yes it
> proceeds with get_xps_queue. If not it proceeds with netdev->ndo_select_queue
> (if defined).
>
> Compile test only.
I do not think its right, take a look at
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c , around line 6467
next prev parent reply other threads:[~2013-05-17 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 8:48 [PATCH net-next] net: netdev_pick_tx: use get_xps_q if xps map is set govindarajulu.v
2013-05-17 13:35 ` Eric Dumazet [this message]
2013-05-17 19:50 ` govind
2013-05-17 22:03 ` Eric Dumazet
2013-05-18 5:18 ` govind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368797733.3301.84.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=govindarajulu90@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox