From: Eric Dumazet <eric.dumazet@gmail.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: small skb_segment() cleanup
Date: Fri, 17 May 2013 10:27:46 -0700 [thread overview]
Message-ID: <1368811666.3301.111.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAHLZz11hoXDQ3ie2jBnfpQG7+SqgCuNMBA087ms3M+OPtnhqKA@mail.gmail.com>
On Fri, 2013-05-17 at 10:20 -0700, Harvey Harrison wrote:
> On Fri, May 17, 2013 at 10:13 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
>
>
> > @@ -2817,7 +2817,6 @@ struct sk_buff *skb_segment(struct sk_buff *skb, netdev_features_t features)
> >
> > nskb->truesize += skb_end_offset(nskb) - hsize;
> > skb_release_head_state(nskb);
> > - __skb_push(nskb, doffset);
>
> is __skb_push equivalent to __skb_put?
Doh... right you are !
prev parent reply other threads:[~2013-05-17 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 17:13 [PATCH net-next] net: small skb_segment() cleanup Eric Dumazet
2013-05-17 17:20 ` Harvey Harrison
2013-05-17 17:27 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368811666.3301.111.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox