From: Nikolay Aleksandrov <nikolay@redhat.com>
To: netdev@vger.kernel.org
Cc: fubar@us.ibm.com, andy@greyhouse.net, davem@davemloft.net
Subject: [PATCH v2 0/4] bonding: race and inconsistency fixes
Date: Sat, 18 May 2013 13:18:27 +0200 [thread overview]
Message-ID: <1368875911-4952-1-git-send-email-nikolay@redhat.com> (raw)
Hello,
In patch 1/4 a race condition while changing the bonding mode through
sysfs is fixed. Since no synchronization method is used it can race
with different functions resulting in different impacts. RTNL is used
to sync with the most important and dangerous events.
Patch 2/4 is trivial and improves the debugging output by changing %x
format to %pI4 for IPv4 addresses in a few pr_debug() calls.
Patch 3/4 fixes an inconsistent arp_targets state where we have 0 entry
between (or in the beginning) the valid entries that were obtained which
is hard to diagnose otherwise.
Patch 4/4 fixes multiple instances of a race condition which is because of
calls to bond_3ad_get_active_agg_info without any locking, and since it
traverses the slave list this can easily result in NULL ptr dereference or
use of freed memory.
v2 is to address a minor style fix, to make the wrapper
global and move it to bond_3ad.c, and also to fix the naming of the
functions, all in patch 4/4.
Best regards,
Nikolay Aleksandrov
Nikolay Aleksandrov (4):
bonding: fix set mode race conditions
bonding: replace %x with %pI4 for IPv4 addresses
bonding: arp_ip_count and arp_targets can be wrong
bonding: fix multiple 3ad mode sysfs race conditions
drivers/net/bonding/bond_3ad.c | 21 +++++++++++++++++----
drivers/net/bonding/bond_3ad.h | 2 ++
drivers/net/bonding/bond_main.c | 25 +++++++++++--------------
drivers/net/bonding/bond_procfs.c | 2 +-
drivers/net/bonding/bond_sysfs.c | 13 ++++++++-----
5 files changed, 39 insertions(+), 24 deletions(-)
--
1.8.1.4
next reply other threads:[~2013-05-18 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 11:18 Nikolay Aleksandrov [this message]
2013-05-18 11:18 ` [PATCH v2 1/4] bonding: fix set mode race conditions Nikolay Aleksandrov
2013-05-18 11:18 ` [PATCH v2 2/4] bonding: replace %x with %pI4 for IPv4 addresses Nikolay Aleksandrov
2013-05-18 11:18 ` [PATCH v2 3/4] bonding: arp_ip_count and arp_targets can be wrong Nikolay Aleksandrov
2013-05-18 21:28 ` Sergei Shtylyov
2013-05-18 11:18 ` [PATCH v2 4/4] bonding: fix multiple 3ad mode sysfs race conditions Nikolay Aleksandrov
2013-05-20 6:26 ` [PATCH v2 0/4] bonding: race and inconsistency fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368875911-4952-1-git-send-email-nikolay@redhat.com \
--to=nikolay@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).