From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: jeffrey.t.kirsher@intel.com
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Wei Yang <weiyang@linux.vnet.ibm.com>
Subject: [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split
Date: Mon, 20 May 2013 16:15:05 +0800 [thread overview]
Message-ID: <1369037707-27026-3-git-send-email-weiyang@linux.vnet.ibm.com> (raw)
In-Reply-To: <1369037707-27026-1-git-send-email-weiyang@linux.vnet.ibm.com>
In structure e1000_rx_desc_packet_split, the size of wb.upper.length is
defined by a digit. This may introduce some problem when the lenght is
changed.
This patch use the marco PS_PAGE_BUFFERS for the definition. And move the
definition to hw.h.
Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
drivers/net/ethernet/intel/e1000e/e1000.h | 3 ---
drivers/net/ethernet/intel/e1000e/hw.h | 5 ++++-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h
index fcc7581..3ba560d 100644
--- a/drivers/net/ethernet/intel/e1000e/e1000.h
+++ b/drivers/net/ethernet/intel/e1000e/e1000.h
@@ -90,9 +90,6 @@ struct e1000_info;
#define E1000_MNG_VLAN_NONE (-1)
-/* Number of packet split data buffers (not including the header buffer) */
-#define PS_PAGE_BUFFERS (MAX_PS_BUFFERS - 1)
-
#define DEFAULT_JUMBO 9234
/* Time to wait before putting the device into D3 if there's no link (in ms). */
diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
index 1e6b889..edc618ad 100644
--- a/drivers/net/ethernet/intel/e1000e/hw.h
+++ b/drivers/net/ethernet/intel/e1000e/hw.h
@@ -227,6 +227,9 @@ union e1000_rx_desc_extended {
};
#define MAX_PS_BUFFERS 4
+
+/* Number of packet split data buffers (not including the header buffer) */
+#define PS_PAGE_BUFFERS (MAX_PS_BUFFERS - 1)
/* Receive Descriptor - Packet Split */
union e1000_rx_desc_packet_split {
struct {
@@ -251,7 +254,7 @@ union e1000_rx_desc_packet_split {
} middle;
struct {
__le16 header_status;
- __le16 length[3]; /* length of buffers 1-3 */
+ __le16 length[PS_PAGE_BUFFERS]; /* length of buffers 1-3 */
} upper;
__le64 reserved;
} wb; /* writeback */
--
1.7.5.4
next prev parent reply other threads:[~2013-05-20 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 8:15 [PATCH 0/4] trivial clean up for e1000e driver Wei Yang
2013-05-20 8:15 ` [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:24 ` Wei Yang
2013-05-20 8:15 ` Wei Yang [this message]
2013-05-20 9:37 ` [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split Jeff Kirsher
2013-05-20 16:24 ` Wei Yang
2013-05-20 8:15 ` [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:25 ` Wei Yang
2013-08-22 10:57 ` Jeff Kirsher
2013-08-22 14:26 ` Wei Yang
2013-05-20 8:15 ` [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used Wei Yang
2013-05-20 9:38 ` Jeff Kirsher
2013-05-20 16:25 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369037707-27026-3-git-send-email-weiyang@linux.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).