From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] x86: bpf_jit_comp: secure bpf jit against spraying attacks
Date: Mon, 20 May 2013 06:52:12 -0700 [thread overview]
Message-ID: <1369057932.3301.171.camel@edumazet-glaptop> (raw)
In-Reply-To: <5199F1E3.1020109@redhat.com>
On Mon, 2013-05-20 at 11:50 +0200, Daniel Borkmann wrote:
> Here seems also to be another approach ...
>
> http://grsecurity.net/~spender/jit_prot.diff
>
> via: http://www.reddit.com/r/netsec/comments/13dzhx/linux_kernel_jit_spray_for_smep_kernexec_bypass/
Well, there are many approaches, and I have another one as well provided
by H. Peter Anvin.
Idea was to allow the code being relocated outside of the 2GB space that
we use for kernel code (including module_alloc())
So every call helper, coded in "e8 xx xx xx xx" was replaced by
"48 c7 c0 yy yy yy yy mov $foo,%rax"
"ff d0 call *%rax"
The RO protection + random holes idea was a solution with no performance
impact.
Another idea is to limit BPF JIT to root users. I do not think BPF JIT
is mandatory at all, as tcpdump is already restricted.
next prev parent reply other threads:[~2013-05-20 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 2:37 [PATCH net-next] x86: bpf_jit_comp: secure bpf jit against spraying attacks Eric Dumazet
2013-05-19 17:02 ` Daniel Borkmann
2013-05-20 6:55 ` David Miller
2013-05-20 6:56 ` David Miller
2013-05-20 8:51 ` David Laight
2013-05-20 9:50 ` Daniel Borkmann
2013-05-20 13:52 ` Eric Dumazet [this message]
2013-05-20 13:34 ` Eric Dumazet
2013-05-20 14:19 ` Florian Westphal
2013-05-20 14:26 ` Eric Dumazet
2013-05-20 14:35 ` David Laight
2013-05-24 17:23 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369057932.3301.171.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox