From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's Date: Mon, 20 May 2013 17:07:15 +0100 Message-ID: <1369066035.4616.6.camel@bwh-desktop.uk.solarflarecom.com> References: <1368586102-17661-1-git-send-email-yinghai@kernel.org> <20130515091248.00002fe3@unknown> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Greg Rose , Yinghai Lu , Bjorn Helgaas , Gu Zheng , , , Alexander Duyck , Yan Burman , Sathya Perla , To: Or Gerlitz Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2013-05-20 at 15:28 +0300, Or Gerlitz wrote: > On Wed, May 15, 2013 at 7:12 PM, Greg Rose wrote: > > > > I'm really not a fan of this. Seems to me the tail is wagging the dog > > here. Fix the driver to work without a PF driver being present. > > Greg, Alex, > > As I wrote over the V1 thread, currently we can't go and patch mlx4 to > use the sysfs API nor defer the call from within our probe function to > enable sriov since this requires some firmware change to allow > enabling SRIOV after some resources are initialized/provisioned. > Hence the patch suggested here or any other patch we can agree on > which will make sure that VF probing is done only once the PF is ready > is preferred, I think. > > I wasn't sure to totally follow on the argument that things need to > work when the PF is absent in the sense there's no driver instance > around over which the PF is probed, if you can explain little better, > that would help. It might be sufficient to return -EPROBE_DEFER from the VF probe function when the PF is not yet ready, if you can easily detect that. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.