From: Eric Dumazet <eric.dumazet@gmail.com>
To: jorge@dti2.net
Cc: netdev@vger.kernel.org, linux-ppp@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/4] ppp_mppe: check coherency counter for out-of-order sequencing
Date: Tue, 21 May 2013 11:36:17 -0700 [thread overview]
Message-ID: <1369161377.3301.246.camel@edumazet-glaptop> (raw)
In-Reply-To: <1369160304-31967-2-git-send-email-jorge@dti2.net>
On Tue, 2013-05-21 at 20:18 +0200, Jorge Boncompte [DTI2] wrote:
> From: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
> if (!state->stateful) {
> + if (mppe_cmp_ccount(ccount, state->ccount) < 0) {
> + if (net_ratelimit())
> + printk(KERN_WARNING "%s[%d]: Dropping out-of-order "
> + "packet with ccount %u, "
> + "expecting %u!\n", __func__,
> + state->unit, ccount, state->ccount);
> + return DECOMP_DROPERROR;
> + }
You did not address my review, thats too bad.
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#107: FILE: drivers/net/ppp/ppp_mppe.c:483:
+
+/*
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
#117: FILE: drivers/net/ppp/ppp_mppe.c:564:
+ printk(KERN_WARNING "%s[%d]: Dropping out-of-order "
WARNING: quoted string split across lines
#118: FILE: drivers/net/ppp/ppp_mppe.c:565:
+ printk(KERN_WARNING "%s[%d]: Dropping out-of-order "
+ "packet with ccount %u, "
next prev parent reply other threads:[~2013-05-21 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 18:18 [RFC PATCH v2 1/4] ppp: adds new error for decompressors to signal that packet must be dropped Jorge Boncompte [DTI2]
2013-05-21 18:18 ` [RFC PATCH v2 2/4] ppp_mppe: check coherency counter for out-of-order sequencing Jorge Boncompte [DTI2]
2013-05-21 18:36 ` Eric Dumazet [this message]
2013-05-21 18:40 ` Sergei Shtylyov
2013-05-21 18:18 ` [RFC PATCH v2 3/4] ppp_mppe: cleanup kernel log messages Jorge Boncompte [DTI2]
2013-05-21 18:40 ` Joe Perches
2013-05-21 18:18 ` [RFC PATCH v2 4/4] ppp_mppe: style cleanup Jorge Boncompte [DTI2]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369161377.3301.246.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=jorge@dti2.net \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox