* [PATCH] virtio_net: enable napi after enabling new queues
@ 2013-05-22 5:22 Jason Wang
2013-05-22 5:46 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2013-05-22 5:22 UTC (permalink / raw)
To: rusty, mst; +Cc: netdev, linux-kernel, Sasha Levin, virtualization
Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx
queues which are being used) forgets to enable napi for new enabled queues which
breaks the multiqueue receiving. This patch fixes it.
Cc: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/net/virtio_net.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 2d6abac..9b2f59f 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -914,9 +914,11 @@ static int virtnet_set_queues(struct virtnet_info *vi, u16 queue_pairs)
queue_pairs);
return -EINVAL;
} else {
- for (i = vi->curr_queue_pairs; i < queue_pairs; i++)
+ for (i = vi->curr_queue_pairs; i < queue_pairs; i++) {
if (!try_fill_recv(&vi->rq[i], GFP_KERNEL))
schedule_delayed_work(&vi->refill, 0);
+ virtnet_napi_enable(&vi->rq[i]);
+ }
vi->curr_queue_pairs = queue_pairs;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] virtio_net: enable napi after enabling new queues
2013-05-22 5:22 [PATCH] virtio_net: enable napi after enabling new queues Jason Wang
@ 2013-05-22 5:46 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2013-05-22 5:46 UTC (permalink / raw)
To: Jason Wang; +Cc: mst, netdev, linux-kernel, virtualization, Sasha Levin
On 05/22/2013 01:22 PM, Jason Wang wrote:
> Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx
> queues which are being used) forgets to enable napi for new enabled queues which
> breaks the multiqueue receiving. This patch fixes it.
>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/net/virtio_net.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 2d6abac..9b2f59f 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -914,9 +914,11 @@ static int virtnet_set_queues(struct virtnet_info *vi, u16 queue_pairs)
> queue_pairs);
> return -EINVAL;
> } else {
> - for (i = vi->curr_queue_pairs; i < queue_pairs; i++)
> + for (i = vi->curr_queue_pairs; i < queue_pairs; i++) {
> if (!try_fill_recv(&vi->rq[i], GFP_KERNEL))
> schedule_delayed_work(&vi->refill, 0);
> + virtnet_napi_enable(&vi->rq[i]);
> + }
> vi->curr_queue_pairs = queue_pairs;
> }
>
A bug were found in this patch, will send a new version.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-22 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22 5:22 [PATCH] virtio_net: enable napi after enabling new queues Jason Wang
2013-05-22 5:46 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).