From: "Florian Fainelli" <f.fainelli@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, afleming@freescale.com, jogo@openwrt.org,
bhutchings@solarflare.com,
"Florian Fainelli" <f.fainelli@gmail.com>
Subject: [PATCH 1/3 net-next v3] net: ethtool: disambiguate XCVR_* meaning
Date: Thu, 23 May 2013 12:11:11 +0100 [thread overview]
Message-ID: <1369307473-20696-2-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1369307473-20696-1-git-send-email-f.fainelli@gmail.com>
Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and
Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and
Ethernet MAC in a different package/die). Most if not all of the drivers
setting their transceiver type already do it the way the comment
describes it.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
include/uapi/linux/ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 0c9b448..38dbafa 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -993,8 +993,8 @@ enum ethtool_sfeatures_retval_bits {
#define PORT_OTHER 0xff
/* Which transceiver to use. */
-#define XCVR_INTERNAL 0x00
-#define XCVR_EXTERNAL 0x01
+#define XCVR_INTERNAL 0x00 /* PHY and MAC are in the same package */
+#define XCVR_EXTERNAL 0x01 /* PHY and MAC are in different packages */
#define XCVR_DUMMY1 0x02
#define XCVR_DUMMY2 0x03
#define XCVR_DUMMY3 0x04
--
1.8.1.2
next prev parent reply other threads:[~2013-05-23 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 11:11 [PATCH 0/3 v3] phy: allow flagging PHY devices as internal Florian Fainelli
2013-05-23 11:11 ` Florian Fainelli [this message]
2013-05-27 16:49 ` [PATCH 1/3 net-next v3] net: ethtool: disambiguate XCVR_* meaning Ben Hutchings
2013-05-23 11:11 ` [PATCH 2/3 net-next v3] phy: allow drivers to flag a PHY device as internal Florian Fainelli
2013-05-23 11:11 ` [PATCH 3/3 net-next v3] phy: bcm63xx: report Broadcom BCM63xx PHYs " Florian Fainelli
2013-05-24 21:31 ` [PATCH 0/3 v3] phy: allow flagging PHY devices " Florian Fainelli
2013-05-26 6:36 ` David Miller
2013-05-28 5:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369307473-20696-2-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=afleming@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jogo@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).