* [PATCH 1/1] net-next: export skb_splice_bits()
@ 2013-05-23 17:09 Michel Machado
2013-05-23 19:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michel Machado @ 2013-05-23 17:09 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Eric Dumazet, Pravin B Shelar, linux-kernel
skb_splice_bits() is already available in include/linux/skbuff.h, but
without EXPORT_SYMBOL it can't be used by kernel modules.
Signed-off-by: Michel Machado <michel@digirati.com.br>
CC: "David S. Miller" <davem@davemloft.net>
CC: Eric Dumazet <edumazet@google.com>
CC: Pravin B Shelar <pshelar@nicira.com>
---
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index af9185d..0976908 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1854,6 +1854,7 @@ done:
return ret;
}
+EXPORT_SYMBOL(skb_splice_bits);
/**
* skb_store_bits - store bits from kernel buffer to skb
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] net-next: export skb_splice_bits()
2013-05-23 17:09 [PATCH 1/1] net-next: export skb_splice_bits() Michel Machado
@ 2013-05-23 19:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-23 19:23 UTC (permalink / raw)
To: michel; +Cc: netdev, edumazet, pshelar, linux-kernel
Ummm, no.
You don't export every single function just because it appears in a header
file.
When we have an in-kernel module that needs these functions, we can
export them, but no sooner.
So until you submit a set of changes that use these routines from modules
we're not exporting them.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-23 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 17:09 [PATCH 1/1] net-next: export skb_splice_bits() Michel Machado
2013-05-23 19:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).