Re: [PATCH] ip_gre: fix kernel panic with icmp_dest_unreach

[Eric Dumazet <eric.dumazet@gmail.com>]

On Thu, 2013-05-23 at 19:59 +0300, Daniel Petre wrote:
> On May 23, 2013, at 6:53 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
> > On Thu, 2013-05-23 at 11:47 +0300, Daniel Petre wrote:
> > 
> >> 
> >> Hello again Eric,
> >> we applied the little patch from:
> >> http://lkml.indiana.edu/hypermail/linux/kernel/1007.0/00961.html
> >> we have flapped the link few times and everything recovered smooth.
> >> 
> > 
> > Thats a very good catch, now we have to fix the bug at the right place.
> > 
> 
> Hey Eric,
> maybe this could work?
> 
> --- linux-3.8.13/net/ipv4/ip_gre.c.orig	2013-05-23 19:54:58.317798942 +0300
> +++ linux-3.8.13/net/ipv4/ip_gre.c	2013-05-23 19:56:30.290029424 +0300
> @@ -882,7 +882,7 @@ static netdev_tx_t ipgre_tunnel_xmit(str
>  		if (time_before(jiffies,
>  				tunnel->err_time + IPTUNNEL_ERR_TIMEO)) {
>  			tunnel->err_count--;
> -
> +			memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
>  			dst_link_failure(skb);
>  		} else
>  			tunnel->err_count = 0;
> 

Not exactly, please try the patch I sent.

Thanks !