From: Cong Wang <amwang@redhat.com>
To: Mike Rapoport <mike.rapoport@ravellosystems.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [Patch net-next v8 02/11] ipv6: make ip6_dst_hoplimit() static inline
Date: Fri, 24 May 2013 13:10:18 +0800 [thread overview]
Message-ID: <1369372218.5590.1.camel@cr0> (raw)
In-Reply-To: <20130522161013.GA10184@zed>
On Wed, 2013-05-22 at 19:10 +0300, Mike Rapoport wrote:
> I've lost you here... Why not just:
>
> static inline
> bool vxlan_addr_equal(const union vxlan_addr *a, const union vxlan_addr *b)
> {
> if (a->sa.sa_family != b->sa.sa_family)
> return false;
> if (a->sa.sa_family == AF_INET6)
> return ipv6_addr_equal(&a->sin6.sin6_addr, &b->sin6.sin6_addr);
> else
> return a->sin.sin_addr.s_addr == b->sin.sin_addr.s_addr;
> }
I see your point now, but for !CONFIG_IPV6, the first two 'if' is
obviously useless. Is GCC smart enough to know ->sa.sa_family ==
AF_INET4 is always true in such case? I doubt...
next prev parent reply other threads:[~2013-05-24 5:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 0:21 [Patch net-next v8 00/11] vxlan: add ipv6 support Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 01/11] vxlan: defer vxlan init as late as possible Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 02/11] ipv6: make ip6_dst_hoplimit() static inline Cong Wang
2013-05-17 13:02 ` Sergei Shtylyov
2013-05-17 21:13 ` David Miller
2013-05-22 4:54 ` Cong Wang
2013-05-22 7:14 ` David Miller
2013-05-22 10:28 ` Cong Wang
2013-05-22 15:50 ` Mike Rapoport
2013-05-22 16:03 ` Cong Wang
2013-05-22 16:10 ` Mike Rapoport
2013-05-24 5:10 ` Cong Wang [this message]
2013-05-24 5:15 ` Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 03/11] ipv6: move ip6_local_out into core kernel Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 04/11] ipv6: export a stub for IPv6 symbols used by vxlan Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 05/11] ipv6: export in6addr_loopback to modules Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 06/11] vxlan: add ipv6 support Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 07/11] vxlan: respect disable_ipv6 sysctl Cong Wang
2013-05-17 13:07 ` Sergei Shtylyov
2013-05-17 0:21 ` [Patch net-next v8 08/11] vxlan: add ipv6 route short circuit support Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 09/11] vxlan: add ipv6 proxy support Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 10/11] vxlan: respect scope_id for ll addr Cong Wang
2013-05-17 0:21 ` [Patch net-next v8 11/11] ipv6: Add generic UDP Tunnel segmentation Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369372218.5590.1.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).