From mboxrd@z Thu Jan 1 00:00:00 1970 From: atomlin@redhat.com Subject: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets Date: Sun, 26 May 2013 21:19:17 +0100 Message-ID: <1369599557-22677-1-git-send-email-atomlin@redhat.com> Cc: davem@davemloft.net, edumazet@google.com, pshelar@nicira.com, mst@redhat.com, alexander.h.duyck@intel.com, riel@redhat.com, aquini@redhat.com, sergei.shtylyov@cogentembedded.com, linux-kernel@vger.kernel.org, Aaron Tomlin To: netdev@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Aaron Tomlin Since v1: - Removed unnecessary parentheses ---8<--- Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless, but they still cause users to panic and file bug reports over dropped packets. It would be better to hide the failed allocation warnings and backtraces, and let retransmits handle dropped packets quietly. Signed-off-by: Aaron Tomlin --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 02139d6..84aa870 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -236,7 +236,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, ? skbuff_fclone_cache : skbuff_head_cache; if (sk_memalloc_socks() && (flags & SKB_ALLOC_RX)) - gfp_mask |= (__GFP_MEMALLOC|__GFP_NOWARN); + gfp_mask |= __GFP_MEMALLOC | __GFP_NOWARN; /* Get the HEAD */ skb = kmem_cache_alloc_node(cache, gfp_mask & ~__GFP_DMA, node); -- 1.8.1.4