* [PATCH] fec_ptp: Use a more standard logging
@ 2013-05-27 19:10 Fabio Estevam
2013-05-28 6:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-05-27 19:10 UTC (permalink / raw)
To: davem; +Cc: netdev, Fabio Estevam
It is preferable to use netdev_err when possible.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/freescale/fec_ptp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 25fc960..588dd91 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -17,8 +17,6 @@
* 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/string.h>
@@ -380,6 +378,6 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev)
fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
if (IS_ERR(fep->ptp_clock)) {
fep->ptp_clock = NULL;
- pr_err("ptp_clock_register failed\n");
+ netdev_err(ndev, "ptp_clock_register failed\n");
}
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fec_ptp: Use a more standard logging
2013-05-27 19:10 [PATCH] fec_ptp: Use a more standard logging Fabio Estevam
@ 2013-05-28 6:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-28 6:25 UTC (permalink / raw)
To: fabio.estevam; +Cc: netdev
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Mon, 27 May 2013 16:10:26 -0300
> @@ -17,8 +17,6 @@
> * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
> */
>
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
> #include <linux/module.h>
I don't see any justification for this part of your change, and at the
very least it's not mentioned nor explained in your commit message.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-28 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-27 19:10 [PATCH] fec_ptp: Use a more standard logging Fabio Estevam
2013-05-28 6:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).