* [PATCH] openvswitch: use -EEXIST as return error to be more precise
@ 2013-05-28 6:31 Fan Du
2013-05-29 6:50 ` David Miller
2013-05-29 18:02 ` Jesse Gross
0 siblings, 2 replies; 3+ messages in thread
From: Fan Du @ 2013-05-28 6:31 UTC (permalink / raw)
To: jesse; +Cc: davem, netdev
ovs_vport_cmd_new create a new vport with port num specified by user.
when this port num is already occupied, it's more clear to return
-EEXIST as the reason than -EBUSY.
Signed-off-by: Fan Du <fan.du@windriver.com>
---
net/openvswitch/datapath.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index d12d6b8..1e31095 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -1755,7 +1755,7 @@ static int ovs_vport_cmd_new(struct sk_buff *skb, struct genl_info *info)
goto exit_unlock;
vport = ovs_vport_ovsl(dp, port_no);
- err = -EBUSY;
+ err = -EEXIST;
if (vport)
goto exit_unlock;
} else {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] openvswitch: use -EEXIST as return error to be more precise
2013-05-28 6:31 [PATCH] openvswitch: use -EEXIST as return error to be more precise Fan Du
@ 2013-05-29 6:50 ` David Miller
2013-05-29 18:02 ` Jesse Gross
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-05-29 6:50 UTC (permalink / raw)
To: fan.du; +Cc: jesse, netdev
From: Fan Du <fan.du@windriver.com>
Date: Tue, 28 May 2013 14:31:16 +0800
> ovs_vport_cmd_new create a new vport with port num specified by user.
> when this port num is already occupied, it's more clear to return
> -EEXIST as the reason than -EBUSY.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
Jesse?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] openvswitch: use -EEXIST as return error to be more precise
2013-05-28 6:31 [PATCH] openvswitch: use -EEXIST as return error to be more precise Fan Du
2013-05-29 6:50 ` David Miller
@ 2013-05-29 18:02 ` Jesse Gross
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Gross @ 2013-05-29 18:02 UTC (permalink / raw)
To: Fan Du; +Cc: David Miller, netdev, dev@openvswitch.org
On Tue, May 28, 2013 at 3:31 PM, Fan Du <fan.du@windriver.com> wrote:
> ovs_vport_cmd_new create a new vport with port num specified by user.
> when this port num is already occupied, it's more clear to return
> -EEXIST as the reason than -EBUSY.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
This error code is part of the userspace ABI so you can't change it
without breaking existing applications.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-29 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 6:31 [PATCH] openvswitch: use -EEXIST as return error to be more precise Fan Du
2013-05-29 6:50 ` David Miller
2013-05-29 18:02 ` Jesse Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).