From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, horms@verge.net.au
Subject: Re: [Patch net-next] net: clean up skb headers code
Date: Wed, 29 May 2013 14:48:06 +0800 [thread overview]
Message-ID: <1369810086.12227.18.camel@cr0> (raw)
In-Reply-To: <20130528.233647.1209227470109213894.davem@davemloft.net>
On Tue, 2013-05-28 at 23:36 -0700, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Wed, 29 May 2013 14:09:00 +0800
>
> > commit 1a37e412a0225fcba5587 (net: Use 16bits for *_headers
> > fields of struct skbuff) converts skb->*_header to u16,
> > therefore 1) we could just use 0xFFFFF instead of (__u16) ~0U
> > 2) some #if NET_SKBUFF_DATA_USES_OFFSET is useless now.
> >
> >
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Simon Horman <horms@verge.net.au>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
>
> I want to use something that will either break the build or
> automatically work if the type changes again.
>
> So something like "X = (typeof(X)) ~0U;".
Yeah, this is even better. I will update this patch.
Thanks.
next prev parent reply other threads:[~2013-05-29 6:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 6:09 [Patch net-next] net: clean up skb headers code Cong Wang
2013-05-29 6:36 ` David Miller
2013-05-29 6:48 ` Cong Wang [this message]
2013-05-29 6:49 ` David Miller
2013-05-29 19:34 ` Ben Hutchings
2013-05-29 19:44 ` Antonio Quartulli
2013-05-29 21:02 ` Ben Hutchings
2013-05-30 8:59 ` Antonio Quartulli
2013-05-30 11:41 ` David Laight
2013-05-30 11:45 ` Antonio Quartulli
2013-05-30 12:12 ` David Laight
2013-05-30 12:22 ` David Laight
2013-05-30 12:24 ` Antonio Quartulli
2013-05-30 12:40 ` David Laight
2013-05-30 12:23 ` Antonio Quartulli
2013-05-30 1:59 ` Cong Wang
2013-05-30 12:30 ` Sergei Shtylyov
2013-05-30 10:40 ` David Miller
2013-05-30 14:11 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369810086.12227.18.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).