From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Willem de Bruijn <willemb@google.com>,
Don, Eliezer Tamir <eliezer.tamir@linux.intel.com>,
Or Gerlitz <or.gerlitz@gmail.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
HPA <hpa@zytor.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Alex Rosenbaum <alexr@mellanox.com>,
linux-kernel@vger.kernel.org,
Eliezer Tamir <eliezer@tamir.org.il>,
Andi Kleen <andi@firstfloor.org>,
Eilon Greenstien <eilong@broadcom.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v6 net-next 1/5] net: add napi_id and hash
Date: Wed, 29 May 2013 06:43:45 -0700 [thread overview]
Message-ID: <1369835025.5109.21.camel@edumazet-glaptop> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7256@saturn3.aculab.com>
On Wed, 2013-05-29 at 14:09 +0100, David Laight wrote:
> > > Adds a napi_id and a hashing mechanism to lookup a napi by id.
>
> Is this one of the places where the 'id' can be selected
> so that the 'hash' lookup never collides?
Very few devices will ever call napi_hash_add()
[ Real NIC RX queues, not virtual devices ]
We use a hash table with 256 slots, the chance of collision is about 0%
Lets not over engineer the thing before its even used.
------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2013-05-29 13:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 6:39 [PATCH v6 net-next 0/5] net: low latency Ethernet device polling Eliezer Tamir
2013-05-29 6:39 ` [PATCH v6 net-next 1/5] net: add napi_id and hash Eliezer Tamir
2013-05-29 12:56 ` Eric Dumazet
2013-05-29 13:09 ` David Laight
2013-05-29 13:43 ` Eric Dumazet [this message]
2013-05-29 15:04 ` Eliezer Tamir
2013-05-29 20:09 ` Ben Hutchings
2013-05-30 6:51 ` Eliezer Tamir
2013-05-29 6:39 ` [PATCH v6 net-next 2/5] net: implement support for low latency socket polling Eliezer Tamir
2013-05-29 13:37 ` Eric Dumazet
2013-05-29 13:42 ` David Laight
2013-05-29 13:48 ` Eric Dumazet
2013-05-29 14:01 ` Eliezer Tamir
2013-05-29 14:20 ` yaniv saar
2013-05-29 15:01 ` Eliezer Tamir
2013-05-29 14:14 ` Or Gerlitz
2013-05-29 14:40 ` yaniv saar
2013-05-29 14:59 ` Eliezer Tamir
2013-05-29 18:52 ` Or Gerlitz
2013-05-29 19:08 ` Eric Dumazet
2013-05-30 5:58 ` Eliezer Tamir
2013-05-30 6:04 ` Eliezer Tamir
2013-05-29 20:20 ` Ben Hutchings
2013-05-29 6:39 ` [PATCH v6 net-next 3/5] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-29 13:38 ` Eric Dumazet
2013-05-29 6:39 ` [PATCH v6 net-next 4/5] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-29 6:40 ` [PATCH v6 net-next 5/5] ixgbe: add extra stats " Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369835025.5109.21.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=alexr@mellanox.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox